Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review TomcatStarter as it's servlet-specific but not in a servlet-specific package #44325

Open
wilkinsona opened this issue Feb 18, 2025 · 0 comments
Open

Review TomcatStarter as it's servlet-specific but not in a servlet-specific package #44325

wilkinsona opened this issue Feb 18, 2025 · 0 comments
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Milestone
4.0.x

Comments

@wilkinsona
Copy link
Member

While TomcatEmbeddedContext has a TomcatStarter field, it's only ever non-null when the context has been created by TomcatServletWebServerFactory. Review this arrangement to see if TomcatStarter can become servlet-specific and move to the same package as TomcatServletWebServerFactory. This would allow it to become package-private.
@wilkinsona wilkinsona added status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task labels Feb 18, 2025
@wilkinsona wilkinsona added this to the 4.0.x milestone Feb 18, 2025
@wilkinsona wilkinsona mentioned this issue Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
1 participant
@wilkinsona