Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Spring Boot 3.3.1 to Spring Boot 3.4.1 appears to have caused performance regression #44341

Open
frankjkelly opened this issue Feb 18, 2025 · 3 comments
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged

Comments

@frankjkelly
Copy link

frankjkelly commented Feb 18, 2025

We are seeing this at the median and p99 across multiple services

API Service 1
Before
Image

After (this reaches less than half the load of the "before" test case)
Image

API for Service 2
Before
Image

After (this also reaches less than half the load of the "before" test case)
Image

The only thing we see so far that might explain is that the Hikari Connection Pool (for our Postgres DB) seems higher in both cases
suggesting either Postgres Driver / Hibernate / JPA may be involved potentially.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2025
@wilkinsona
Copy link
Member

Thanks for the report. Unfortunately, it isn’t actionable in its current form as it provides only minimal information about the affected services and how they’re implemented.

You’ve mentioned Postgres. Best guess at the moment is that this is similar to the performance problems mentioned in the comments on #44214.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 18, 2025
@frankjkelly
Copy link
Author

@wilkinsona Thanks yeah I figured it wasn't enough but just in case other someone else pieces it all together before we do hopefully they might drop an idea here.

Thanks for the Postgres idea sadly it doesn't match our case (however it is good to know of those issues in 42.7.5 for sure)
Image

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 18, 2025
@bclozel bclozel added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Feb 18, 2025
@LeoTheDarvin
Copy link

Hello, @frankjkelly . Is the issue relevant for you still?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 25, 2025
@bclozel bclozel added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

5 participants