Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the situation with support for Prometheus PushGateway and the deprecated simpleclient #44392

Open
breun opened this issue Feb 21, 2025 · 3 comments
Labels
type: documentation A documentation update
Milestone

Comments

@breun
Copy link
Contributor

breun commented Feb 21, 2025

Spring Boot 3.4's Prometheus documentation says:

The Prometheus Pushgateway only works with the deprecated Prometheus simpleclient for now, until the Prometheus 1.x client adds support for it.

The Prometheus 1.x client added PushGateway support in version 1.3.0, so the blocker mentioned above is gone. I think it would be good to update this documentation note to reflect that.

Also, I don't believe the PushGateway support in the Prometheus 1.x client gets auto-configured yet, so I think this still needs to be added in Spring Boot 3.4?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2025
@wilkinsona wilkinsona changed the title PushGateway support with Prometheus 1.x client in Spring Boot 3.4 Clarify the situation with support for Prometheus PushGateway and the deprecated simpleclient Feb 21, 2025
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 21, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Feb 21, 2025
@wilkinsona
Copy link
Member

We've added support in Spring Boot 3.5. That won't be back ported to 3.4 as we consider it to be a new feature and we don't back port new features to maintenance branches.

We can use this issue to clarify the documentation.

@breun
Copy link
Contributor Author

breun commented Feb 21, 2025

@wilkinsona Thanks for your reply. I see the milestone has been set to 3.3.x, but I think this should be 3.4.x?

@wilkinsona
Copy link
Member

It's applicable to 3.3.x as well because its documentation contains the same note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants