Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenTelemetry's service.namespace #44411

Open
nosan opened this issue Feb 23, 2025 · 4 comments
Open

Add support for OpenTelemetry's service.namespace #44411

nosan opened this issue Feb 23, 2025 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@nosan
Copy link
Contributor

nosan commented Feb 23, 2025

As per the OpenTelemetry documentation (https://opentelemetry.io/docs/specs/semconv/attributes-registry/service), service.group does not exist. Instead, service.namespace should be used for this purpose.

service.namespace:

A string value having a meaning that helps to distinguish a group of services, for example the team name that owns a group of services. service.name is expected to be unique within the same namespace. If service.namespace is not specified in the Resource then service.name is expected to be unique for all services that have no explicit namespace defined (so the empty/unspecified namespace is simply one more valid namespace). Zero-length namespace string is assumed equal to unspecified namespace.

service.group is set up in both OpenTelemetryAutoConfiguration and OtlpMetricsPropertiesConfigAdapter

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 23, 2025
@mhalbritter
Copy link
Contributor

service.group has been added in #39957. Currently it's only exposed via OTel and logging (without the field name).

To not break backwards compatibility, we should support both service.group and service.namespace for some time. service.namespace has been mentioned here, too.

@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2025
@mhalbritter mhalbritter added this to the 3.x milestone Feb 25, 2025
@mhalbritter mhalbritter changed the title Use 'service.namespace' instead of 'service.group' for OpenTelemetry Add support for OpenTelemetry's service.namespace Feb 25, 2025
@thecooldrop
Copy link

Hello @mhalbritter, may I be assigned this issue?

@mhalbritter
Copy link
Contributor

Hello @thecooldrop, thanks for wanting to work on this. I think we should first merge #44394, otherwise there will be a lot of merge conflicts.

I'll assign you to the issue, but please hold off for now. Thanks!

@mhalbritter
Copy link
Contributor

@thecooldrop I merged the PR, it's on main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants