Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Querydsl predicate binding on WebFlux [DATACMNS-1785] #2200

Closed
spring-projects-issues opened this issue Aug 11, 2020 · 8 comments
Closed

Support for Querydsl predicate binding on WebFlux [DATACMNS-1785] #2200

spring-projects-issues opened this issue Aug 11, 2020 · 8 comments
Assignees
@mp911de
Labels
in: web Integration with Spring MVC type: enhancement A general enhancement
Milestone
2.5 M3 (2021.0.0)

Comments

@spring-projects-issues
Copy link

Oliver Drotbohm opened DATACMNS-1785 and commented

The binding of request parameters to a Querydsl Predicate is currently only supported for WebMVC. We're currently lacking integration with WebFlux parameter resolution

No further details from DATACMNS-1785
@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Integration with Spring MVC labels Dec 30, 2020
@matiasah
Copy link
Contributor

Any due date?

@mp911de
Copy link
Member

mp911de commented Jan 13, 2021

Feel free to submit a pull request to speed up things.

@matiasah
Copy link
Contributor

matiasah commented Jan 15, 2021 •
edited
Loading

I noticed there's a web package for WebMVC related configuration. Where should I put WebFlux configuration files?

@matiasah
Copy link
Contributor

On the other hand, is it necessary to have a custom @EnableSpringDataWebFluxSupport as mentioned in #1846 ?

@matiasah matiasah mentioned this issue Jan 16, 2021
Closed
@mp911de
Copy link
Member

mp911de commented Jan 18, 2021

For now, we have very few utilities that could be registered through @EnableSpringDataWebFluxSupport.

What you're looking for is a reactive variant of QuerydslPredicateArgumentResolver that should live side-by-side with QuerydslPredicateArgumentResolver. ReactivePageableHandlerMethodArgumentResolver is located in the web package specifically as we didn't intend to make a distinction between WebMVC and WebFlux.

Pulling out the common bits of QuerydslPredicateArgumentResolver (similar to PageableHandlerMethodArgumentResolverSupport) would be the way to go.

@matiasah
Copy link
Contributor

Should I change the name of the class from QuerydslPredicateArgumentResolver to ReactiveQuerydslPredicateArgumentResolver?

@mp911de
Copy link
Member

mp911de commented Jan 19, 2021

Yes, please. Let's continue the discussion regarding the code changes in #2274.

mp911de pushed a commit that referenced this issue Jan 25, 2021
@matiasah @mp911de
DATACMNS-1785 - Add ReactiveQuerydslPredicateArgumentResolver and Rea…
a839690 
…ctiveQuerydslWebConfiguration.

We now provide ReactiveQuerydslPredicateArgumentResolver to resolve Querydsl Predicates when using Spring WebFlux.

Related ticket: #2200.
Original pull request: #2274.
mp911de added a commit that referenced this issue Jan 25, 2021
@mp911de
DATACMNS-1785 - Polishing.
d57fb3e 
Introduce constructors accepting non-null ConversionService, handle conversion service defaulting in configuration classes by using ObjectProvider. Extract common code to create a predicate in getPredicate(…) method. Add unit test.

Convert spaces to tabs.

Related ticket: #2200.
Original pull request: #2274.
@mp911de mp911de added this to the 2.5 M3 (2021.0.0) milestone Jan 25, 2021
@mp911de
Copy link
Member

mp911de commented Jan 25, 2021

That's in place now.

@mp911de mp911de closed this as completed Jan 25, 2021
@mp911de mp911de assigned mp911de and unassigned odrotbohm Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: web Integration with Spring MVC type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M3 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

DATACMNS-1785 - Add QuerydslWebFluxConfiguration and QuerydslPredicateArgumentResolver
4 participants
@odrotbohm @mp911de @matiasah @spring-projects-issues