Skip to content

Commit 55a3112

Browse files
Seol-JYmp911de
authored andcommitted
Add @Serial annotation to all serialVersionUID fields.
- Enhance code readability and maintainability - Improve static analysis capabilities - Ensure proper declaration of serialVersionUID fields Closes #3584
1 parent 90a8b15 commit 55a3112

File tree

14 files changed

+33
-15
lines changed

14 files changed

+33
-15
lines changed

Diff for: spring-data-envers/src/test/java/org/springframework/data/envers/sample/QCountry.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,16 @@
2323

2424
import static com.querydsl.core.types.PathMetadataFactory.forVariable;
2525

26+
import java.io.Serial;
27+
2628
/**
2729
* Query class for Country domain.
2830
*
2931
* @author Dmytro Iaroslavskyi
3032
*/
3133
public class QCountry extends EntityPathBase<Country> {
3234

33-
private static final long serialVersionUID = -936338527;
35+
@Serial private static final long serialVersionUID = -936338527;
3436

3537
private static final PathInits INITS = PathInits.DIRECT2;
3638

Diff for: spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/JpaSort.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.springframework.lang.Nullable;
2323
import org.springframework.util.Assert;
2424

25+
import java.io.Serial;
2526
import java.util.ArrayList;
2627
import java.util.Arrays;
2728
import java.util.Collection;
@@ -39,7 +40,7 @@
3940
*/
4041
public class JpaSort extends Sort {
4142

42-
private static final long serialVersionUID = 1L;
43+
@Serial private static final long serialVersionUID = 1L;
4344

4445
private JpaSort(Direction direction, List<Path<?, ?>> paths) {
4546
this(Collections.<Order>emptyList(), direction, paths);
@@ -316,7 +317,7 @@ public String toString() {
316317
*/
317318
public static class JpaOrder extends Order {
318319

319-
private static final long serialVersionUID = 1L;
320+
@Serial private static final long serialVersionUID = 1L;
320321

321322
private final boolean unsafe;
322323

Diff for: spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/Specification.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import jakarta.persistence.criteria.Predicate;
2121
import jakarta.persistence.criteria.Root;
2222

23+
import java.io.Serial;
2324
import java.io.Serializable;
2425
import java.util.Arrays;
2526
import java.util.stream.StreamSupport;
@@ -40,7 +41,7 @@
4041
*/
4142
public interface Specification<T> extends Serializable {
4243

43-
long serialVersionUID = 1L;
44+
@Serial long serialVersionUID = 1L;
4445

4546
/**
4647
* Negates the given {@link Specification}.

Diff for: spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/InvalidJpaQueryMethodException.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package org.springframework.data.jpa.repository.query;
1717

18+
import java.io.Serial;
19+
1820
/**
1921
* Signals that we encountered an invalid query method.
2022
*
@@ -23,7 +25,7 @@
2325
*/
2426
public class InvalidJpaQueryMethodException extends RuntimeException {
2527

26-
private static final long serialVersionUID = 1L;
28+
@Serial private static final long serialVersionUID = 1L;
2729

2830
/**
2931
* Creates a new {@link InvalidJpaQueryMethodException} with the given message.

Diff for: spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import jakarta.persistence.criteria.Predicate;
3232
import jakarta.persistence.criteria.Root;
3333

34+
import java.io.Serial;
3435
import java.util.ArrayList;
3536
import java.util.Collection;
3637
import java.util.Collections;
@@ -945,7 +946,7 @@ private static long executeCountQuery(TypedQuery<Long> query) {
945946
@SuppressWarnings("rawtypes")
946947
private static final class ByIdsSpecification<T> implements Specification<T> {
947948

948-
private static final long serialVersionUID = 1L;
949+
@Serial private static final long serialVersionUID = 1L;
949950

950951
private final JpaEntityInformation<T, ?> entityInformation;
951952

@@ -974,7 +975,7 @@ public Predicate toPredicate(Root<T> root, CriteriaQuery<?> query, CriteriaBuild
974975
*/
975976
private static class ExampleSpecification<T> implements Specification<T> {
976977

977-
private static final long serialVersionUID = 1L;
978+
@Serial private static final long serialVersionUID = 1L;
978979

979980
private final Example<T> example;
980981
private final EscapeCharacter escapeCharacter;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/Account.java

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
19+
1820
import jakarta.persistence.Entity;
1921

2022
import org.springframework.data.jpa.domain.AbstractPersistable;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/EmbeddedIdExampleEmployeePK.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
1819
import java.io.Serializable;
1920

2021
import jakarta.persistence.Column;
@@ -25,7 +26,7 @@
2526
*/
2627
@Embeddable
2728
public class EmbeddedIdExampleEmployeePK implements Serializable {
28-
private static final long serialVersionUID = 1L;
29+
@Serial private static final long serialVersionUID = 1L;
2930

3031
@Column(nullable = false) private Long employeeId;
3132

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/IdClassExampleEmployeePK.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
1819
import java.io.Serializable;
1920

2021
/**
2122
* @author Thomas Darimont
2223
*/
2324
public class IdClassExampleEmployeePK implements Serializable {
24-
private static final long serialVersionUID = 1L;
25+
@Serial private static final long serialVersionUID = 1L;
2526

2627
private long empId;
2728
private long department;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemId.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
1819
import java.io.Serializable;
1920

2021
/**
@@ -25,7 +26,7 @@
2526
*/
2627
public class ItemId implements Serializable {
2728

28-
private static final long serialVersionUID = -2986871112875450036L;
29+
@Serial private static final long serialVersionUID = -2986871112875450036L;
2930

3031
private Integer id;
3132
private Integer manufacturerId;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemSiteId.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
1819
import java.io.Serializable;
1920

2021
/**
@@ -25,7 +26,7 @@
2526
*/
2627
public class ItemSiteId implements Serializable {
2728

28-
private static final long serialVersionUID = 1822540289216799357L;
29+
@Serial private static final long serialVersionUID = 1822540289216799357L;
2930

3031
private ItemId item;
3132
private Integer site;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/PersistableWithIdClassPK.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import static org.springframework.util.ObjectUtils.*;
1919

20+
import java.io.Serial;
2021
import java.io.Serializable;
2122

2223
/**
@@ -25,7 +26,7 @@
2526
*/
2627
public class PersistableWithIdClassPK implements Serializable {
2728

28-
private static final long serialVersionUID = 23126782341L;
29+
@Serial private static final long serialVersionUID = 23126782341L;
2930

3031
private Long first;
3132
private Long second;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/PersistableWithSingleIdClassPK.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,15 @@
1717

1818
import static org.springframework.util.ObjectUtils.*;
1919

20+
import java.io.Serial;
2021
import java.io.Serializable;
2122

2223
/**
2324
* @author Mark Paluch
2425
*/
2526
public class PersistableWithSingleIdClassPK implements Serializable {
2627

27-
private static final long serialVersionUID = 23126782341L;
28+
@Serial private static final long serialVersionUID = 23126782341L;
2829

2930
private Long first;
3031

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/SampleEntityPK.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
1819
import java.io.Serializable;
1920

2021
import jakarta.persistence.Column;
@@ -25,7 +26,7 @@
2526
@Embeddable
2627
public class SampleEntityPK implements Serializable {
2728

28-
private static final long serialVersionUID = 231060947L;
29+
@Serial private static final long serialVersionUID = 231060947L;
2930

3031
@Column(nullable = false)
3132
private String first;

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/Site.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18+
import java.io.Serial;
19+
1820
import jakarta.persistence.Entity;
1921
import jakarta.persistence.GeneratedValue;
2022
import jakarta.persistence.Id;
@@ -31,7 +33,7 @@
3133
@Table
3234
public class Site implements java.io.Serializable {
3335

34-
private static final long serialVersionUID = 1L;
36+
@Serial private static final long serialVersionUID = 1L;
3537

3638
@Id @GeneratedValue Integer id;
3739

0 commit comments

Comments
 (0)