Skip to content

Commit c116755

Browse files
gregturngregturn
committed
Polishing.
Also added more test cases from related pull requests. Closes #2582. Related: #2563, #2557, #2603
1 parent 1ae67c8 commit c116755

File tree

2 files changed

+80
-63
lines changed

2 files changed

+80
-63
lines changed

Diff for: ‎src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java

+5-17
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,10 @@
2626
import java.util.regex.Pattern;
2727
import java.util.stream.Collectors;
2828

29-
import javax.persistence.EntityManager;
30-
import javax.persistence.ManyToOne;
31-
import javax.persistence.OneToOne;
32-
import javax.persistence.Parameter;
33-
import javax.persistence.Query;
34-
import javax.persistence.criteria.CriteriaBuilder;
35-
import javax.persistence.criteria.Expression;
36-
import javax.persistence.criteria.Fetch;
37-
import javax.persistence.criteria.From;
38-
import javax.persistence.criteria.Join;
39-
import javax.persistence.criteria.JoinType;
40-
import javax.persistence.metamodel.Attribute;
29+
import javax.persistence.*;
30+
import javax.persistence.criteria.*;
31+
import javax.persistence.metamodel.*;
4132
import javax.persistence.metamodel.Attribute.PersistentAttributeType;
42-
import javax.persistence.metamodel.Bindable;
43-
import javax.persistence.metamodel.ManagedType;
44-
import javax.persistence.metamodel.PluralAttribute;
45-
import javax.persistence.metamodel.SingularAttribute;
4633

4734
import org.springframework.core.annotation.AnnotationUtils;
4835
import org.springframework.dao.InvalidDataAccessApiUsageException;
@@ -105,7 +92,8 @@ public abstract class QueryUtils {
10592
private static final Pattern ALIAS_MATCH;
10693
private static final Pattern COUNT_MATCH;
10794
private static final Pattern STARTS_WITH_PAREN = Pattern.compile("^\\s*\\(");
108-
private static final Pattern PARENS_TO_REMOVE = Pattern.compile("(\\(.*\\bfrom\\b[^)]+\\))", CASE_INSENSITIVE | DOTALL | MULTILINE);
95+
private static final Pattern PARENS_TO_REMOVE = Pattern.compile("(\\(.*\\bfrom\\b[^)]+\\))",
96+
CASE_INSENSITIVE | DOTALL | MULTILINE);
10997
private static final Pattern PROJECTION_CLAUSE = Pattern.compile("select\\s+(?:distinct\\s+)?(.+)\\s+from",
11098
Pattern.CASE_INSENSITIVE);
11199

Diff for: ‎src/test/java/org/springframework/data/jpa/repository/query/QueryUtilsUnitTests.java

+75-46
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
*/
1616
package org.springframework.data.jpa.repository.query;
1717

18-
import static org.assertj.core.api.Assertions.*;
18+
import static org.assertj.core.api.Assertions.assertThat;
19+
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
1920
import static org.springframework.data.jpa.repository.query.QueryUtils.*;
2021

2122
import java.util.Collections;
@@ -46,6 +47,7 @@
4647
* @author Jędrzej Biedrzycki
4748
* @author Darin Manica
4849
* @author Chris Fraser
50+
* @author Michał Pachucki
4951
*/
5052
class QueryUtilsUnitTests {
5153

@@ -184,55 +186,82 @@ void testRemoveSubqueries() throws Exception {
184186
@Test // GH-2581
185187
void testRemoveMultilineSubqueries() {
186188

187-
assertThat(normalizeWhitespace(removeSubqueries("select u from User u\n"
188-
+ " where not exists (\n"
189-
+ " from User u2\n"
190-
+ " )")))
191-
.isEqualTo("select u from User u where not exists");
192-
assertThat(normalizeWhitespace(removeSubqueries("(\n"
193-
+ " select u from User u \n"
194-
+ " where not exists (\n"
195-
+ " from User u2\n"
196-
+ " )\n"
197-
+ ")")))
198-
.isEqualTo("( select u from User u where not exists )");
199-
assertThat(normalizeWhitespace(
200-
removeSubqueries("select u from User u \n"
201-
+ " where not exists (\n"
202-
+ " from User u2 \n"
203-
+ " where not exists (\n"
204-
+ " from User u3\n"
205-
+ " )\n"
206-
+ " )")))
207-
.isEqualTo("select u from User u where not exists");
208-
assertThat(normalizeWhitespace(
209-
removeSubqueries("select u from User u \n"
210-
+ " where not exists (\n"
211-
+ " (\n"
212-
+ " from User u2 \n"
213-
+ " where not exists (\n"
214-
+ " from User u3\n"
215-
+ " )\n"
216-
+ " )\n"
217-
+ " )")))
218-
.isEqualTo("select u from User u where not exists ( )");
219-
assertThat(normalizeWhitespace(
220-
removeSubqueries("(\n"
221-
+ " select u from User u \n"
222-
+ " where not exists (\n"
223-
+ " (\n"
224-
+ " from User u2 \n"
225-
+ " where not exists (\n"
226-
+ " from User u3\n"
227-
+ " )\n"
228-
+ " )\n"
229-
+ " )\n"
230-
+ ")")))
231-
.isEqualTo("( select u from User u where not exists ( ) )");
189+
assertThat(normalizeWhitespace(removeSubqueries("select u from User u\n" //
190+
+ " where not exists (\n" //
191+
+ " from User u2\n" //
192+
+ " )"))).isEqualTo("select u from User u where not exists");
193+
194+
assertThat(normalizeWhitespace(removeSubqueries("(\n" //
195+
+ " select u from User u \n" //
196+
+ " where not exists (\n" //
197+
+ " from User u2\n" //
198+
+ " )\n" //
199+
+ ")"))).isEqualTo("( select u from User u where not exists )");
200+
201+
assertThat(normalizeWhitespace(removeSubqueries("select u from User u \n" //
202+
+ " where not exists (\n" //
203+
+ " from User u2 \n" //
204+
+ " where not exists (\n" //
205+
+ " from User u3\n" //
206+
+ " )\n" //
207+
+ " )"))).isEqualTo("select u from User u where not exists");
208+
209+
assertThat(normalizeWhitespace(removeSubqueries("select u from User u \n" //
210+
+ " where not exists (\n" //
211+
+ " (\n" //
212+
+ " from User u2 \n" //
213+
+ " where not exists (\n" //
214+
+ " from User u3\n" //
215+
+ " )\n" //
216+
+ " )\n" //
217+
+ " )"))).isEqualTo("select u from User u where not exists ( )");
218+
219+
assertThat(normalizeWhitespace(removeSubqueries("(\n" //
220+
+ " select u from User u \n" //
221+
+ " where not exists (\n" //
222+
+ " (\n" //
223+
+ " from User u2 \n" //
224+
+ " where not exists (\n" //
225+
+ " from User u3\n" //
226+
+ " )\n" //
227+
+ " )\n" //
228+
+ " )\n" //
229+
+ ")"))).isEqualTo("( select u from User u where not exists ( ) )");
230+
}
231+
232+
@Test // GH-2557
233+
void applySortingAccountsForNewlinesInSubselect() {
234+
235+
Sort sort = Sort.by(Order.desc("age"));
236+
237+
assertThat(QueryUtils.applySorting("select u\n" + //
238+
"from user u\n" + //
239+
"where exists (select u2\n" + //
240+
"from user u2\n" + //
241+
")\n" + //
242+
"", sort)).isEqualTo("select u\n" + //
243+
"from user u\n" + //
244+
"where exists (select u2\n" + //
245+
"from user u2\n" + //
246+
")\n" + //
247+
" order by u.age desc");
248+
}
249+
250+
@Test // GH-2563
251+
void aliasDetectionProperlyHandlesNewlinesInSubselects() {
252+
253+
assertThat(detectAlias("SELECT o\n" + //
254+
"FROM Order o\n" + //
255+
"AND EXISTS(SELECT 1\n" + //
256+
"FROM Vehicle vehicle\n" + //
257+
"WHERE vehicle.vehicleOrderId = o.id\n" + //
258+
"AND LOWER(COALESCE(vehicle.make, '')) LIKE :query)")).isEqualTo("o");
232259
}
233260

234261
private String normalizeWhitespace(String s) {
262+
235263
Matcher matcher = MULTI_WHITESPACE.matcher(s);
264+
236265
if (matcher.find()) {
237266
return matcher.replaceAll(" ").trim();
238267
}

0 commit comments

Comments
 (0)