Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enable/disable option for Ignore case #2617

Closed
mvishnumohan opened this issue Aug 10, 2022 · 5 comments
Closed

Add Enable/disable option for Ignore case #2617

mvishnumohan opened this issue Aug 10, 2022 · 5 comments
Assignees
Labels
status: duplicate A duplicate of another issue

Comments

@mvishnumohan
Copy link

Methods like findByNameIgnoringCase is adding UPPER irrespective of db level configurations and not hitting the indexes. In the scenario, we are supporting mssql and postgres, where postgres needs UPPER in where clause to achieve IgnoreCase whereas MSSQL does not need it. The query will work but it will not hit / use the index on name. Mssql doesnot support functions in Index otherwise we could have add an index with UPPER(name).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 10, 2022
@schauder
Copy link
Contributor

There was a similar issue reported a while ago. Not sure if it was for Spring Data JPA or JDBC. And can't find it anymore It was asking for making the function used (lower vs upper) configurable. We probably allow for three options: lower, upper, none

@schauder schauder added the type: enhancement A general enhancement label Aug 10, 2022
@schauder schauder added the status: pending-design-work Needs design work before any code can be developed label Aug 29, 2022
@schauder
Copy link
Contributor

We should also consider introducing a configuration object that can also hold the escape character.

@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2022
@gregturn
Copy link
Contributor

gregturn commented Sep 20, 2022

#2420 is the issue where we aligned ALL querying, be it JPA or Querydsl, to use the same modifier for ignoresCase suffixes. Since Querydsl was using lower, we ensure everything else did the same.

That issue DID make a request to make this configurable. I will scan the code to see how invasive such a flag setting would be, and to see how easy it would be for Spring Boot to also access it should we apply it.

@OrangeDog
Copy link

OrangeDog commented Feb 15, 2024

@gregturn that issue is where you said you would do that. But the associated commits did not appear to do that. It didn't add any tests to confirm it either.

@mp911de mp911de added status: duplicate A duplicate of another issue and removed status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement labels Nov 22, 2024
@mp911de
Copy link
Member

mp911de commented Nov 22, 2024

Closing as duplicate of #2420

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

6 participants