No argument for named parameter using parameter multiple times with IN binding

[AlexanderShchelkunov]

Description

Hello!

I have encountered the problem in version 3.3.9 (works fine in 3.3.8).
When I have a query with a parameter, that used multiple time in query with paging, I have the following error:
org.springframework.dao.InvalidDataAccessResourceUsageException: No argument for named parameter ':logins_1'
It is important to have more data in the database, than page size, to trigger additional count query.
Example of the query:

@Query(
  value = """
      SELECT d
      FROM UserEntity d
      WHERE (:logins) IS NULL OR LOWER(d.login) IN (:logins)
      """
)
Page<UserEntity> findByLogins(@Param("logins") Set<String> logins, Pageable pageable);

Environment

Spring Boot: 3.3.9
Java: JDK 17

Steps to Reproduce

To reproduce the defect run the app and the error will occur during @PostConstruct execution in UserService

Error Message

Caused by: org.hibernate.QueryParameterException: No argument for named parameter ':logins_1'
	at org.hibernate.query.internal.QueryParameterBindingsImpl.lambda$validate$0(QueryParameterBindingsImpl.java:142) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) ~[na:na]
	at java.base/java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092) ~[na:na]
	at org.hibernate.query.internal.ParameterMetadataImpl.visitParameters(ParameterMetadataImpl.java:191) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.spi.ParameterMetadataImplementor.visitRegistrations(ParameterMetadataImplementor.java:29) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.internal.QueryParameterBindingsImpl.validate(QueryParameterBindingsImpl.java:138) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.spi.AbstractSelectionQuery.beforeQuery(AbstractSelectionQuery.java:446) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.spi.AbstractSelectionQuery.beforeQueryHandlingFetchProfiles(AbstractSelectionQuery.java:439) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.spi.AbstractSelectionQuery.list(AbstractSelectionQuery.java:420) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.hibernate.query.Query.getResultList(Query.java:120) ~[hibernate-core-6.5.3.Final.jar:6.5.3.Final]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution$PagedExecution.count(JpaQueryExecution.java:211) ~[spring-data-jpa-3.3.9.jar:3.3.9]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution$PagedExecution.lambda$0(JpaQueryExecution.java:206) ~[spring-data-jpa-3.3.9.jar:3.3.9]
	at org.springframework.data.support.PageableExecutionUtils.getPage(PageableExecutionUtils.java:63) ~[spring-data-commons-3.3.9.jar:3.3.9]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution$PagedExecution.doExecute(JpaQueryExecution.java:205) ~[spring-data-jpa-3.3.9.jar:3.3.9]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution.execute(JpaQueryExecution.java:93) ~[spring-data-jpa-3.3.9.jar:3.3.9]
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.doExecute(AbstractJpaQuery.java:152) ~[spring-data-jpa-3.3.9.jar:3.3.9]
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.execute(AbstractJpaQuery.java:140) ~[spring-data-jpa-3.3.9.jar:3.3.9]
...

Minimal sample application

See the attachment:
QueryParameterException_demo.zip

[x41dev]

Hello,

I had similar case and I've found workaround: When I used :#{#logins} instead of :logins problem disappear.
Maybe it will help somehow

[AlexanderShchelkunov]

Hello,

I had similar case and I've found workaround: When I used :#{#logins} instead of :logins problem disappear. Maybe it will help somehow

Hi @x41dev!
Thanks for sharing the workaround. It's very helpful!

[hkucharek-pgt]

We had the same problem with 3.4.3 and after downgrading to 3.4.2 it worked again.

[mp911de]

Regression was introduced through 88b6ea2. New snapshots are on their way into repo.spring.io. Care to upgrade to and test against 3.3.10-SNAPSHOT?

[AlexanderShchelkunov]

Regression was introduced through 88b6ea2. New snapshots are on their way into repo.spring.io. Care to upgrade to and test against 3.3.10-SNAPSHOT?

Hi @mp911de!
Thanks for the fix! It works fine in 3.3.10-SNAPSHOT.

[mp911de]

Thanks for verifying.

[mcs]

Will this patch also be part of the upcoming 3.4.4 release, as 3.4.3 also has that problem as mentioned in #3789 ?

[mp911de]

Yes, the fix will be shipped with 3.4.4, 3.3.10. and 3.5.0-M2.