Skip to content

Migrate to JSpecify annotations for nullability constraints #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mp911de opened this issue Jan 15, 2025 · 3 comments
Open

Migrate to JSpecify annotations for nullability constraints #3092

mp911de opened this issue Jan 15, 2025 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Member

mp911de commented Jan 15, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 15, 2025
@AnneMayor
Copy link
Contributor

@mp911de can you explain to me what the leftover is? I would like to open PR to resolve this issue if you don't mind.

@mp911de
Copy link
Member Author

mp911de commented Mar 18, 2025

This ticket needs to be fully resolved. Migrating off org.springframework.lang.@Nullable|@NonNullApi to use JSpecifys @Nullable and @NullMarked (on the package), adding missing annotations to all Template API implementations and ensuring that NullAway does not report any nullability errors. This is quite an effort, even for a seasoned Spring developer so I recommend that you leave this one to us except if you are looking for a difficult-to-master adventure along with a hard time looking for workarounds.

@AnneMayor
Copy link
Contributor

Oh, I see. Thanks for your comment. For now, I think it would be better to resolve others. I would challenge a difficult-to-master adventure if I resolve lots of issues and understand the whole picture of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants