Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis INFO output is parsed as (Java) properties, although it is not the same format #3099

Open
DamianFekete opened this issue Feb 6, 2025 · 1 comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement

Comments

@DamianFekete
Copy link

DamianFekete commented Feb 6, 2025

The issue is the same as here #1281
That issue was closed because:

Redis on Windows is no longer supported. As this variant has no future I'm inclined to not include any Windows-specific changes to Spring Data Redis

There are Redis variants for Windows that are newer than version 3.
https://github.com/ponfee/embedded-redis/tree/master currently uses 6.2.7.
https://github.com/redis-windows/redis-windows has version 7.

Although we're not using the Windows versions in production, they are helpful for developers using a Windows machine.

Technically speaking, the INFO output should not be parsed as Properties as it is not encoded as such.

My current workaround is to set the TEMP/TMP environment variables so that they don't point to c:\users\..., as the \u.... raises the exception.
I've tried to start Redis as c:/.../redis-server.exe but the changed separator only works for the configuration file, not exe path in the INFO output.

Would you reconsider the previous decision?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 6, 2025
@mp911de
Copy link
Member

mp911de commented Feb 10, 2025

Using properties parsing seemed to be the simplemost approach. We'd be happy to review a pull request.

@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants