Skip to content

Commit 642adee

Browse files
committed
Implement advice from the code review.
See #992 Original pull request #993
1 parent 887f17b commit 642adee

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

Diff for: spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/AggregateReferenceConverters.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* @author Jens Schauder
3535
* @since 2.6
3636
*/
37-
final class AggregateReferenceConverters {
37+
class AggregateReferenceConverters {
3838
/**
3939
* Prevent instantiation.
4040
*/
@@ -45,11 +45,11 @@ private AggregateReferenceConverters() {}
4545
* delegate {@link ConversionService}.
4646
*/
4747
@WritingConverter
48-
public static class AggregateReferenceToSimpleTypeConverter implements GenericConverter {
48+
static class AggregateReferenceToSimpleTypeConverter implements GenericConverter {
4949

5050
private final ConversionService delegate;
5151

52-
public AggregateReferenceToSimpleTypeConverter(ConversionService delegate) {
52+
AggregateReferenceToSimpleTypeConverter(ConversionService delegate) {
5353
this.delegate = delegate;
5454
}
5555

@@ -90,11 +90,11 @@ public Object convert(@Nullable Object source, TypeDescriptor sourceDescriptor,
9090
* {@link ConversionService}.
9191
*/
9292
@ReadingConverter
93-
public static class SimpleTypeToAggregateReferenceConverter implements GenericConverter {
93+
static class SimpleTypeToAggregateReferenceConverter implements GenericConverter {
9494

9595
private final ConversionService delegate;
9696

97-
public SimpleTypeToAggregateReferenceConverter(ConversionService delegate) {
97+
SimpleTypeToAggregateReferenceConverter(ConversionService delegate) {
9898
this.delegate = delegate;
9999
}
100100

@@ -110,7 +110,6 @@ public Object convert(@Nullable Object source, TypeDescriptor sourceDescriptor,
110110
return null;
111111
}
112112

113-
// TODO check
114113
ResolvableType componentType = targetDescriptor.getResolvableType().getGenerics()[1];
115114
TypeDescriptor targetType = TypeDescriptor.valueOf(componentType.resolve());
116115
Object convertedId = delegate.convert(source, TypeDescriptor.valueOf(source.getClass()), targetType);

0 commit comments

Comments
 (0)