More optimal RequestMethod condition lookup

See gh-22644

Author: rstoyanchev

spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/RequestMethodsRequestCondition.java

@@ -42,12 +42,13 @@
 public final class RequestMethodsRequestCondition extends AbstractRequestCondition<RequestMethodsRequestCondition> {
 
 	/** Per HTTP method cache to return ready instances from getMatchingCondition. */
-	private static final Map<String, RequestMethodsRequestCondition> requestMethodConditionCache;
+	private static final Map<HttpMethod, RequestMethodsRequestCondition> requestMethodConditionCache;
 
 	static {
 		requestMethodConditionCache = new HashMap<>(RequestMethod.values().length);
 		for (RequestMethod method : RequestMethod.values()) {
-			requestMethodConditionCache.put(method.name(), new RequestMethodsRequestCondition(method));
+			requestMethodConditionCache.put(
+					HttpMethod.valueOf(method.name()), new RequestMethodsRequestCondition(method));
 		}
 	}
 
@@ -123,7 +124,7 @@ public RequestMethodsRequestCondition getMatchingCondition(ServerWebExchange exc
 			}
 			return this;
 		}
-		return matchRequestMethod(exchange.getRequest().getMethodValue());
+		return matchRequestMethod(exchange.getRequest().getMethod());
 	}
 
 	/**
@@ -137,20 +138,20 @@ private RequestMethodsRequestCondition matchPreFlight(ServerHttpRequest request)
 			return this;
 		}
 		HttpMethod expectedMethod = request.getHeaders().getAccessControlRequestMethod();
-		return expectedMethod != null ? matchRequestMethod(expectedMethod.name()) : null;
+		return expectedMethod != null ? matchRequestMethod(expectedMethod) : null;
 	}
 
 	@Nullable
-	private RequestMethodsRequestCondition matchRequestMethod(@Nullable String httpMethod) {
-		if (httpMethod != null) {
-			for (RequestMethod method : getMethods()) {
-				if (httpMethod.matches(method.name())) {
-					return requestMethodConditionCache.get(method.name());
-				}
-			}
-			if (HttpMethod.HEAD.matches(httpMethod) && getMethods().contains(RequestMethod.GET)) {
-				return requestMethodConditionCache.get(HttpMethod.GET.name());
-			}
+	private RequestMethodsRequestCondition matchRequestMethod(@Nullable HttpMethod httpMethod) {
+		if (httpMethod == null) {
+			return null;
+		}
+		RequestMethod requestMethod = RequestMethod.valueOf(httpMethod.name());
+		if (getMethods().contains(requestMethod)) {
+			return requestMethodConditionCache.get(httpMethod);
+		}
+		if (requestMethod.equals(RequestMethod.HEAD) && getMethods().contains(RequestMethod.GET)) {
+			return requestMethodConditionCache.get(HttpMethod.GET);
 		}
 		return null;
 	}

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/RequestMethodsRequestCondition.java

@@ -142,17 +142,19 @@ private RequestMethodsRequestCondition matchPreFlight(HttpServletRequest request
 
 	@Nullable
 	private RequestMethodsRequestCondition matchRequestMethod(String httpMethodValue) {
-		HttpMethod httpMethod = HttpMethod.resolve(httpMethodValue);
-		if (httpMethod != null) {
-			for (RequestMethod method : getMethods()) {
-				if (httpMethod.matches(method.name())) {
-					return requestMethodConditionCache.get(method.name());
-				}
+		RequestMethod requestMethod;
+		try {
+			requestMethod = RequestMethod.valueOf(httpMethodValue);
+			if (getMethods().contains(requestMethod)) {
+				return requestMethodConditionCache.get(httpMethodValue);
 			}
-			if (httpMethod == HttpMethod.HEAD && getMethods().contains(RequestMethod.GET)) {
+			if (requestMethod.equals(RequestMethod.HEAD) && getMethods().contains(RequestMethod.GET)) {
 				return requestMethodConditionCache.get(HttpMethod.GET.name());
 			}
 		}
+		catch (IllegalArgumentException ex) {
+			// Custom request method
+		}
 		return null;
 	}