Skip to content

Commit 941b92c

Browse files
missingdayssbrannen
authored andcommitted
Make inner classes static when feasible
A static nested class does not keep an implicit reference to its enclosing instance. This prevents a common cause of memory leaks and uses less memory per instance of the class. Closes gh-28433
1 parent e26d883 commit 941b92c

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void handleRequest(HttpServerExchange exchange) {
8888
}
8989

9090

91-
private class HandlerResultSubscriber implements Subscriber<Void> {
91+
private static class HandlerResultSubscriber implements Subscriber<Void> {
9292

9393
private final HttpServerExchange exchange;
9494

spring-webflux/src/main/java/org/springframework/web/reactive/resource/VersionResourceResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ protected VersionStrategy getStrategyForPath(String requestPath) {
236236
}
237237

238238

239-
private class FileNameVersionedResource extends AbstractResource implements HttpResource {
239+
private static class FileNameVersionedResource extends AbstractResource implements HttpResource {
240240

241241
private final Resource original;
242242

spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/UndertowRequestUpgradeStrategy.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public Mono<Void> upgrade(ServerWebExchange exchange, WebSocketHandler handler,
8282
}
8383

8484

85-
private class DefaultCallback implements WebSocketConnectionCallback {
85+
private static class DefaultCallback implements WebSocketConnectionCallback {
8686

8787
private final HandshakeInfo handshakeInfo;
8888

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/VersionResourceResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ protected VersionStrategy getStrategyForPath(String requestPath) {
232232
}
233233

234234

235-
private class FileNameVersionedResource extends AbstractResource implements HttpResource {
235+
private static class FileNameVersionedResource extends AbstractResource implements HttpResource {
236236

237237
private final Resource original;
238238

spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/XhrStreamingTransportHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ protected SockJsFrameFormat getFrameFormat(ServerHttpRequest request) {
7575
}
7676

7777

78-
private class XhrStreamingSockJsSession extends StreamingSockJsSession {
78+
private static class XhrStreamingSockJsSession extends StreamingSockJsSession {
7979

8080
public XhrStreamingSockJsSession(String sessionId, SockJsServiceConfig config,
8181
WebSocketHandler wsHandler, Map<String, Object> attributes) {

0 commit comments

Comments
 (0)