Skip to content

Commit e35db33

Browse files
committed
Merge branch '6.2.x'
2 parents df4868b + 26869b0 commit e35db33

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

Diff for: spring-test/src/main/java/org/springframework/test/context/bean/override/BeanOverrideContextCustomizer.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
*/
3535
class BeanOverrideContextCustomizer implements ContextCustomizer {
3636

37-
static final String REGISTRY_BEAN_NAME =
38-
"org.springframework.test.context.bean.override.internalBeanOverrideRegistry";
39-
4037
private static final String INFRASTRUCTURE_BEAN_NAME =
4138
"org.springframework.test.context.bean.override.internalBeanOverridePostProcessor";
4239

@@ -60,7 +57,7 @@ public void customizeContext(ConfigurableApplicationContext context, MergedConte
6057
// AOT processing, since a bean definition cannot be generated for the
6158
// Set<BeanOverrideHandler> argument that it accepts in its constructor.
6259
BeanOverrideRegistry beanOverrideRegistry = new BeanOverrideRegistry(beanFactory);
63-
beanFactory.registerSingleton(REGISTRY_BEAN_NAME, beanOverrideRegistry);
60+
beanFactory.registerSingleton(BeanOverrideRegistry.BEAN_NAME, beanOverrideRegistry);
6461
beanFactory.registerSingleton(INFRASTRUCTURE_BEAN_NAME,
6562
new BeanOverrideBeanFactoryPostProcessor(this.handlers, beanOverrideRegistry));
6663
beanFactory.registerSingleton(EARLY_INFRASTRUCTURE_BEAN_NAME,

Diff for: spring-test/src/main/java/org/springframework/test/context/bean/override/BeanOverrideRegistry.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
import org.springframework.beans.factory.config.ConfigurableBeanFactory;
3030
import org.springframework.util.Assert;
3131

32-
import static org.springframework.test.context.bean.override.BeanOverrideContextCustomizer.REGISTRY_BEAN_NAME;
33-
3432
/**
3533
* An internal class used to track {@link BeanOverrideHandler}-related state after
3634
* the bean factory has been processed and to provide lookup facilities to test
@@ -46,6 +44,8 @@
4644
*/
4745
class BeanOverrideRegistry {
4846

47+
static final String BEAN_NAME = "org.springframework.test.context.bean.override.internalBeanOverrideRegistry";
48+
4949
private static final Log logger = LogFactory.getLog(BeanOverrideRegistry.class);
5050

5151

@@ -63,8 +63,8 @@ class BeanOverrideRegistry {
6363
Assert.notNull(beanFactory, "ConfigurableBeanFactory must not be null");
6464
this.beanFactory = beanFactory;
6565
BeanFactory parentBeanFactory = beanFactory.getParentBeanFactory();
66-
this.parent = (parentBeanFactory != null && parentBeanFactory.containsBean(REGISTRY_BEAN_NAME) ?
67-
parentBeanFactory.getBean(REGISTRY_BEAN_NAME, BeanOverrideRegistry.class) : null);
66+
this.parent = (parentBeanFactory != null && parentBeanFactory.containsBean(BEAN_NAME) ?
67+
parentBeanFactory.getBean(BEAN_NAME, BeanOverrideRegistry.class) : null);
6868
}
6969

7070
/**

Diff for: spring-test/src/main/java/org/springframework/test/context/bean/override/BeanOverrideTestExecutionListener.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ private static void injectFields(TestContext testContext) {
9898
Object testInstance = testContext.getTestInstance();
9999
ApplicationContext applicationContext = testContext.getApplicationContext();
100100

101-
Assert.state(applicationContext.containsBean(BeanOverrideContextCustomizer.REGISTRY_BEAN_NAME), () -> """
101+
Assert.state(applicationContext.containsBean(BeanOverrideRegistry.BEAN_NAME), () -> """
102102
Test class %s declares @BeanOverride fields %s, but no BeanOverrideHandler has been registered. \
103103
If you are using @ContextHierarchy, ensure that context names for bean overrides match \
104104
configured @ContextConfiguration names.""".formatted(testContext.getTestClass().getSimpleName(),
105105
handlers.stream().map(BeanOverrideHandler::getField).filter(Objects::nonNull)
106106
.map(Field::getName).toList()));
107-
BeanOverrideRegistry beanOverrideRegistry = applicationContext
108-
.getBean(BeanOverrideContextCustomizer.REGISTRY_BEAN_NAME, BeanOverrideRegistry.class);
107+
BeanOverrideRegistry beanOverrideRegistry = applicationContext.getBean(BeanOverrideRegistry.BEAN_NAME,
108+
BeanOverrideRegistry.class);
109109

110110
for (BeanOverrideHandler handler : handlers) {
111111
Field field = handler.getField();

0 commit comments

Comments
 (0)