Skip to content

Backport PR #22485 (Exclude jdk package in ShadowingClassLoader) to 5.1 branch #23641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rahulsh1 opened this issue Sep 15, 2019 · 0 comments
Closed

Backport PR #22485 (Exclude jdk package in ShadowingClassLoader) to 5.1 branch #23641

rahulsh1 opened this issue Sep 15, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.1.10

Comments

@rahulsh1
Copy link

rahulsh1 commented Sep 15, 2019 •
edited
Loading

Hitting this issue with Spring 5.1.9.RELEASE:

Caused by: java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by 
org.springframework.instrument.classloading.ShadowingClassLoader@7c3ca3f0 
cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl

Given Spring 5.1 officially supports JDK11, any reasons this PR-22485 that was merged into master branch should not be backported to 5.1 branch?
@jhoeller
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 15, 2019
@jhoeller jhoeller self-assigned this Sep 16, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Sep 16, 2019
@jhoeller jhoeller added this to the 5.1.10 milestone Sep 16, 2019
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.10
Development

No branches or pull requests
3 participants
@jhoeller @rahulsh1 @spring-projects-issues