Proposal to improve performance optimization of AbstractHandlerMethodMapping mapping matching

[conneyjoo]

Hello

First of all, thank you for your great work on Spring-WebMVC. The request mapping mechanism has served developers well over the years, and I really appreciate the thoughtfulness behind its design.

In a project with a large number of variable-style APIs, i am observed performance bottlenecks due to the linear search approach in RequestMappingHandlerMapping. To address this issue, I tried a hierarchical path matching mechanism that organizes the path in a structured way to narrow the search scope by splitting the path into multiple layers using the "/" symbol and utilizing the hierarchical structure to optimize the lookup process. This approach showed good results in optimizing lookup performance.

I am looking forward to whether this approach is in line with Spring's design principles, and if so, I will cooperate on how to improve it together to ensure that it fits well with the existing ecosystem. If this idea resonates, I will be happy to further refine the proposal based on feedback.

Thank you.

This is the detailed design document, which contains the code implementation, unit test, AbstractHandlerMethodMapping and optimized comparison JHM Report

[bclozel]

Hello @conneyjoo and thanks for the detailed proposal.
At one point I had an implementation for this but decided to not pursue because the performance degradation was too high when the application had fewer and simpler endpoints. I'm happy to revisit that decision. Did you compare against this case as well in your benchmarks?

[conneyjoo]

Hello @conneyjoo and thanks for the detailed proposal. At one point I had an implementation for this but decided to not pursue because the performance degradation was too high when the application had fewer and simpler endpoints. I'm happy to revisit that decision. Did you compare against this case as well in your benchmarks?

Thank you very much for your attention. In this document, I have listed benchmarks for two different specifications. I'm not sure if they match the "fewer and simpler endpoints" scenario you mentioned. If not, I can easily run another benchmark based on your specifications.

The link above section 4 of the document.
4. Performance Testing
Test Specifications:
A: 2 controllers, 64 mappings
B: 5 controllers, 156 mappings

[bclozel]

Can you share the implementation and JMH benchmark?

[conneyjoo]

Can you share the implementation and JMH benchmark?

Sure.
implementation:
https://github.com/conneyjoo/spring-framework/blob/main/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/LayeredRequestMappingHandlerMapping.java

jmh:
https://github.com/conneyjoo/spring-framework/blob/main/spring-webmvc/src/jmh/java/org/springframework/web/servlet/mvc/method/LayeredRequestMappingHandlerMappingBenchmark.java
https://github.com/conneyjoo/spring-framework/blob/main/spring-webmvc/src/jmh/java/org/springframework/web/servlet/mvc/method/RequestMappingHandlerMappingBenchmark.java