"rowsExpected" of SqlQuery is not actually used

[quaff]

SqlQuery::setRowsExpected is invoked somewhere, but it make no sense since SqlQuery::getRowsExpected is never invoked anywhere.

We have two options:

1. use it for query.
2. deprecate it for removal.

See GH-34502

[bclozel]

I still don't get it. This is a java-bean style property on this class. While it's not being used in Spring Framework I think it's meant to be used by applications. Do you have any replacement for this to suggest for people using this?

This is not my area of expertise so I'll leave it to other team members to decide on this.

[quaff]

Do you have any replacement for this to suggest for people using this?

I believe it's misused here, the intention of rowsExpected is for performance consideration of creating ArrayList, shouldn't rely on it.
If we decide to keep it, then we should use it for initialCapacity of ArrayList.

spring-framework/spring-jdbc/src/main/java/org/springframework/jdbc/core/RowMapperResultSetExtractor.java

Lines 90 to 97 in 03cce13

	public List<T> extractData(ResultSet rs) throws SQLException {
	List<T> results = (this.rowsExpected > 0 ? new ArrayList<>(this.rowsExpected) : new ArrayList<>());
	int rowNum = 0;
	while (rs.next()) {
	results.add(this.rowMapper.mapRow(rs, rowNum++));
	}
	return results;
	}