apply UnusedLocalVariable
#34489
Draft
apply UnusedLocalVariable
#34489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Potucek <[email protected]>
…e 'testBean'. [UnusedLocalVariable]
…er'. [UnusedLocalVariable]
spring-projects-issues
added
the
status: waiting-for-triage
pankratz76
commented
Feb 25, 2025
| String value = "Sample"; | ||
| Method[] methods = String.class.getMethods(); | ||
| methods = Integer.class.getMethods(); | ||
| // String.class.getMethods(); |
There was a problem hiding this comment.
Here, I'm wondering if the field is required for the test or if just the method call triggers the hint.
I was not able to run it locally—it seems to be special because of the annotation.
Normally, I test locally, but I was not able to. Please excuse this.
| @@ -1,10 +1,10 @@ | |||
| root = true | |||
|
|
|||
| [*.{adoc,bat,groovy,html,java,js,jsp,kt,kts,md,properties,py,rb,sh,sql,svg,txt,xml,xsd}] | |||
| [*] | |||
| charset = utf-8 | |||
There was a problem hiding this comment.
Just for clarification, is the intent to not make this the default?
I have never seen it otherwise, only globally, with the most common encoding being UTF-8.
This is new to me—my previous knowledge was that properties files were the only files not normally encoded in UTF-8, but now even they have switched.
"As of Java 9, properties files switched from being loaded using ISO-8859-1."
Source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encounter unused code with help of CS module
UnusedLocalVariable.Wondering why the CS config needs to be duplicated. The rules seem not to be applied, some of the findings only emerge after adding the corresponding module again.