Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Error Types in Spring GraphQL #1134

Open
neethu-software opened this issue Feb 21, 2025 · 2 comments
Open

Expanding Error Types in Spring GraphQL #1134

neethu-software opened this issue Feb 21, 2025 · 2 comments
Labels
in: core Issues related to config and core support status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged

Comments

@neethu-software
Copy link

Is it possible to add more error types to the Spring errorType? Currently, Spring GraphQL only supports a generalized errorType. Can we include 429 and other common error types?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2025
@bclozel
Copy link
Member

bclozel commented Feb 21, 2025

Interesting! We can consider new error types, of course.
In the case of HTTP 429 "Too many requests", I'm wondering how this is being used in your application.
Does this mean you are implementing a rate-limiting function at the data fetcher level? I guess this is not counting the number of GraphQL requests per minute, otherwise this would be enforced at the HTTP level, not at the data fetcher level. Is your API calculating some cost for each data fetching operation against a point system?

Thanks!

@bclozel bclozel added in: core Issues related to config and core support status: waiting-for-feedback We need additional information before we can continue labels Feb 21, 2025
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues related to config and core support status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants