Skip to content

Align cancelling behavior to graphql-java request execution #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bclozel opened this issue Apr 3, 2025 · 1 comment
Open

Align cancelling behavior to graphql-java request execution #1171

bclozel opened this issue Apr 3, 2025 · 1 comment
Assignees
@bclozel
Labels
in: data Issues related to working with data type: enhancement A general enhancement
Milestone
2.x

Comments

@bclozel
Copy link
Member

bclozel commented Apr 3, 2025

As of graphql-java/graphql-java#3879, cancellation is natively supported by graphql-java at the ExecutionInput level.
We can now retire our custom wrapping of DataFetchers for that and only propagate the cancellation signal from the transport layer to the ExecutionInput#cancel().
@bclozel bclozel added in: data Issues related to working with data type: enhancement A general enhancement labels Apr 3, 2025
@bclozel bclozel added this to the 1.4.0-RC1 milestone Apr 3, 2025
@bclozel bclozel self-assigned this Apr 3, 2025
@bclozel
Copy link
Member Author

bclozel commented Apr 4, 2025

The graphql-java feature is delayed, let's reschedule this for a future release.

@bclozel bclozel modified the milestones: 1.4.0-RC1, 2.x Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: data Issues related to working with data type: enhancement A general enhancement
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
1 participant
@bclozel