Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Configuring Operational Attributes in Embedded Test Servers #938

Open
jzheaux opened this issue Oct 10, 2024 · 3 comments · May be fixed by #1000
Open

Simplify Configuring Operational Attributes in Embedded Test Servers #938

jzheaux opened this issue Oct 10, 2024 · 3 comments · May be fixed by #1000

Comments

@jzheaux
Copy link
Collaborator

jzheaux commented Oct 10, 2024

It would be nice if more of the underlying configuration settings were exposed for UnboundID's InMemoryDirectoryServerConfig. Specifically, it would be nice to add a custom operation interceptor so that test operational attributes can be added.

This would make testing for issues like #446 more flexible.

Instead of exposing support specifically for operational interceptors, though, it would be more flexible to expose a setter in unboundid.EmbeededLdapServerFactoryBean for post-processing the InMemoryDirectoryServerConfig like so:

public void setDirectoryServerConfigurationPostProcessor(Consumer<InMemoryDirectoryServerConfig> postProcessor)

Then, UnboundID's EmbeddedLdapServer could invoke that before starting the directory service, like so:

config.setEnforceAttributeSyntaxCompliance(true);
+ postProcessor.accept(config);

Entry entry ...

Tests should also be added to demonstrate that the constructed EmbeddedLdapServer correctly uses the configured post-processor.

@jzheaux jzheaux added type: enhancement in: test status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Oct 10, 2024
@jzheaux jzheaux added this to the 3.3.0-M1 milestone Oct 10, 2024
@jzheaux jzheaux modified the milestones: 3.3.0-M1, 3.3.x Jan 9, 2025
@etrandafir93
Copy link

hello @jzheaux - I would like to work on this issue, would it be ok?

@jzheaux
Copy link
Collaborator Author

jzheaux commented Feb 3, 2025

Hi, @etrandafir93, for sure. Thanks for volunteering!

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Feb 3, 2025
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue Feb 9, 2025
@etrandafir93 etrandafir93 linked a pull request Feb 9, 2025 that will close this issue
@etrandafir93
Copy link

hello @jzheaux, I have created the PR: #1000 - this is more or less what I had in mind.
What do you think?

PS: I don't know why the dco check fails, I've tried to follow that commit message pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants