Module dependency for common module

[shreyy1234]

I have 3 modules, in this one module name is common.
common
|- datatype
|- infrastructure
|- enums
|- Aggregates

common module has different packages. As this module in common its internal classes of internal packages should be easily accessible.
However using modulith, module. verify fails when I try to use an enum from this common module in any other module.
I can able to resolve this by adding package-info into each subpackage of common module e.g
@org.springframework.modulith.NamedInterface("datatype")
package com.common.datatype;

however, adding package-info into each package is not a clean solution. is there any other way where I could mention this is a shared module so the modularity test should not fail?
Already tried with but it did not work.
@Modulithic(sharedModules = "com.common")
public class Application {

[onjik]

I'm not sure because I haven't tested it, but @Modulthic::sharedModule seems to write the correct package name. {com.common.enum,com.comm.datatype…} like this. In the case of Java's package, it looks hierarchical to see, but I know it is actually recognized as a separate, independent place.
I haven't tested it, so try it.

[shreyy1234]

tried @Modulithic(sharedModules = "com.common", additionalPackages = "com.common.datatype", useFullyQualifiedModuleNames = true) but it does not work without packge-info. getting

org.springframework.modulith.core.Violations: - Module 'com.other' depends on non-exposed type com..common.datatype.testdata within module 'com.common'!

[peterkronenberg]

Did you ever find a solution to this?

[cjacky475]

@shreyy1234, @peterkronenberg, have you guys found out a solution or is this not yet available in this library?

[luciano-fiandesio]

Also interested…Is it possible in Modulith to "mark" a first-level package as "non module" (and propagate to all sub-packages)?

[emileastih1]

Hello,
Have you tried declaring your "common" package as OPEN in a package-info.java?

You can do so like this:

@org.springframework.modulith.ApplicationModule(
type = Type.OPEN
)
package example.common;

Reference: https://docs.spring.io/spring-modulith/reference/fundamentals.html

[shwetakawale]

@emileastih1 do we need to impot anything for "Type", its giving me compilation error, i have upgraded spring modulith to 1.2.1, still same issue

[luciano-fiandesio]

I had the same problem. Check out the Javadoc: https://docs.spring.io/spring-modulith/docs/1.2.1/api/org/springframework/modulith/ApplicationModule.html#type()

[emileastih1]

@shwetakawale yes you need to import the Type from the modulith.ApplicationModule package, here is an example of how the package-info file shoud look like:

@ApplicationModule(type = Type.OPEN)
package org.springsource.restbucks.legacy;

import org.springframework.modulith.ApplicationModule;
import org.springframework.modulith.ApplicationModule.Type;

Note that in my example I am using Java 22 and <spring-modulith.version>1.2.0</spring-modulith.version>.

[simasch]

I exclude such packages because IMO they shouldn't be modules:

 ApplicationModules modules = ApplicationModules.of(Application.class,
            JavaClass.Predicates.resideInAnyPackage("example.configuration..", "example.common..");