Skip to content

Commit 984945d

Browse files
committed
Polish "Respect executor set on container props"
- Remove final keyword from newly added test - Use AssertJ isSameAs for executor comparison
1 parent 6dcc813 commit 984945d

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

spring-pulsar/src/test/java/org/springframework/pulsar/config/ConcurrentPulsarListenerContainerFactoryTests.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import org.junit.jupiter.api.Nested;
2727
import org.junit.jupiter.api.Test;
2828

29-
import org.springframework.core.task.SimpleAsyncTaskExecutor;
29+
import org.springframework.core.task.AsyncTaskExecutor;
3030
import org.springframework.pulsar.core.PulsarConsumerFactory;
3131
import org.springframework.pulsar.listener.PulsarContainerProperties;
3232

@@ -144,23 +144,23 @@ void defaultUsedWhenNotSetOnEndpointNorFactoryProps() {
144144
}
145145

146146
@Nested
147-
class ConsumerTaskExecutor {
147+
class ConsumerTaskExecutorFrom {
148148

149149
@Test
150150
@SuppressWarnings("unchecked")
151-
void factoryValueCopiedWhenCreatingContainer() {
152-
final var factoryProps = new PulsarContainerProperties();
153-
factoryProps.setConsumerTaskExecutor(new SimpleAsyncTaskExecutor());
154-
final var containerFactory = new ConcurrentPulsarListenerContainerFactory<String>(
151+
void factoryPropsUsedWhenSpecified() {
152+
var factoryProps = new PulsarContainerProperties();
153+
AsyncTaskExecutor executor = mock();
154+
factoryProps.setConsumerTaskExecutor(executor);
155+
var containerFactory = new ConcurrentPulsarListenerContainerFactory<String>(
155156
mock(PulsarConsumerFactory.class), factoryProps);
156-
final var endpoint = mock(PulsarListenerEndpoint.class);
157-
// Mockito by default returns 0 for Integer
158-
when(endpoint.getConcurrency()).thenReturn(null);
159-
160-
final var createdContainer = containerFactory.createRegisteredContainer(endpoint);
157+
var endpoint = mock(PulsarListenerEndpoint.class);
158+
when(endpoint.getConcurrency()).thenReturn(1);
161159

162-
final var containerProperties = createdContainer.getContainerProperties();
163-
assertThat(containerProperties.getConsumerTaskExecutor()).isEqualTo(factoryProps.getConsumerTaskExecutor());
160+
var container = containerFactory.createRegisteredContainer(endpoint);
161+
assertThat(container.getContainerProperties())
162+
.extracting(PulsarContainerProperties::getConsumerTaskExecutor)
163+
.isSameAs(executor);
164164
}
165165

166166
}

0 commit comments

Comments
 (0)