Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate protobuf generated test POJOs #1029

Open
onobc opened this issue Feb 11, 2025 · 0 comments
Open

Automate protobuf generated test POJOs #1029

onobc opened this issue Feb 11, 2025 · 0 comments
Labels
theme: testing Issues related to testing type: task A general task

Comments

@onobc
Copy link
Collaborator

onobc commented Feb 11, 2025

The Protobuf POJOs used for testing recently got out of sync w/ reality and tests started failing due to:

java.lang.UnsupportedOperationException: As of 2022/09/29 (release 21.7) makeExtensionsImmutable should not be called from protobuf gencode. If you are seeing this message, your gencode is vulnerable to a denial of service attack. You should regenerate your code using protobuf 25.6 or later. Use the latest version that meets your needs. However, if you understand the risks and wish to continue with vulnerable gencode, you can set the system property -Dcom.google.protobuf.use_unsafe_pre22_gencode on the command line. See security vulnerability: GHSA-h4h5-3hr4-j3g2

Just needed to update the generated POJOs. However, we should automate the process to regeenerate the files when building using a plugin such as https://github.com/google/protobuf-gradle-plugin

@onobc onobc added theme: testing Issues related to testing type: task A general task labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: testing Issues related to testing type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant