Skip to content

Commit 657760a

Browse files
committed
Improve Logging
Closes gh-14837
1 parent 71a51db commit 657760a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

web/src/main/java/org/springframework/security/web/access/intercept/RequestMatcherDelegatingAuthorizationManager.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private RequestMatcherDelegatingAuthorizationManager(
6767
@Override
6868
public AuthorizationDecision check(Supplier<Authentication> authentication, HttpServletRequest request) {
6969
if (this.logger.isTraceEnabled()) {
70-
this.logger.trace(LogMessage.format("Authorizing %s", request));
70+
this.logger.trace(LogMessage.format("Authorizing %s", requestLine(request)));
7171
}
7272
for (RequestMatcherEntry<AuthorizationManager<RequestAuthorizationContext>> mapping : this.mappings) {
7373

@@ -76,7 +76,7 @@ public AuthorizationDecision check(Supplier<Authentication> authentication, Http
7676
if (matchResult.isMatch()) {
7777
AuthorizationManager<RequestAuthorizationContext> manager = mapping.getEntry();
7878
if (this.logger.isTraceEnabled()) {
79-
this.logger.trace(LogMessage.format("Checking authorization on %s using %s", request, manager));
79+
this.logger.trace(LogMessage.format("Checking authorization on %s using %s", requestLine(request), manager));
8080
}
8181
return manager.check(authentication,
8282
new RequestAuthorizationContext(request, matchResult.getVariables()));
@@ -86,6 +86,10 @@ public AuthorizationDecision check(Supplier<Authentication> authentication, Http
8686
return null;
8787
}
8888

89+
private static String requestLine(HttpServletRequest request) {
90+
return request.getMethod() + " " + UrlUtils.buildRequestUrl(request);
91+
}
92+
8993
/**
9094
* Creates a builder for {@link RequestMatcherDelegatingAuthorizationManager}.
9195
* @return the new {@link Builder} instance

0 commit comments

Comments
 (0)