Add support one-time token value customization #16946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projectsgh-16939 Signed-off-by: Max Batischev <[email protected]>
Closes spring-projectsgh-16939 Signed-off-by: Max Batischev <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
evgeniycheban
suggested changes
Apr 20, 2025
There was a problem hiding this comment.
Hi, @franticticktick I've left one comment below with some thoughts regarding token value generation.
| @Override | ||
| public GenerateOneTimeTokenRequest resolve(HttpServletRequest request) { | ||
| String username = request.getParameter("username"); | ||
| if (!StringUtils.hasText(username)) { | ||
| return null; | ||
| } | ||
| return new GenerateOneTimeTokenRequest(username, this.expiresIn); | ||
| return new GenerateOneTimeTokenRequest(username, this.expiresIn, this.tokenValueFactory.get()); |
There was a problem hiding this comment.
I think we should not generate token value here, since it breaks the semantic of GenerateOneTimeTokenRequestResolver which is:
"A strategy for resolving a GenerateOneTimeTokenRequest from the HttpServletRequest".
It might also be confusing for users who provide a custom tokenValueFactory and notice that their factory gets called before OneTimeTokenService#generate method call.
So I would consider passing Supplier<String> tokenValueFactory to GenerateOneTimeTokenRequest and call it in the OneTimeTokenService#generate method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16939