Skip to content

X509PrincipalExtractor is missing FunctionalInterface annotation #16949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
blake-bauman opened this issue Apr 16, 2025 · 1 comment · May be fixed by #16952
Open

X509PrincipalExtractor is missing FunctionalInterface annotation #16949

blake-bauman opened this issue Apr 16, 2025 · 1 comment · May be fixed by #16952
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@blake-bauman
Copy link

The interface X509PrincipalExtractor is actually a Functional Interface, but it is not annotated with @FunctionalInterface.

This isn't technically a bug, but it was easily missed that this could be expressed as a lambda since the IDE didn't report it as a Functional Interface and we thought we needed an implementation class.
@blake-bauman blake-bauman added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Apr 16, 2025
franticticktick added a commit to franticticktick/spring-security that referenced this issue Apr 17, 2025
@franticticktick
Add FunctionalInterface To X509PrincipalExtractor
b6e3d75 
Closes spring-projectsgh-16949

Signed-off-by: Max Batischev <[email protected]>
@franticticktick franticticktick linked a pull request Apr 17, 2025 that will close this issue
Open
@franticticktick
Copy link
Contributor

franticticktick commented Apr 17, 2025 •
edited
Loading

Hi @blake-bauman, this ticket will be resolved via #16952.
There is no need to create a separate ticket for such a small polish. We don't need to track such changes. Feel free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FunctionalInterface To X509PrincipalExtractor franticticktick/spring-security
2 participants
@franticticktick @blake-bauman