Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade spring-shell from 2.0.1 to 2.1.x then to 3.3.x Tab Completion not working anymore #1149

Closed
joanneshen opened this issue Oct 23, 2024 · 2 comments
Labels
status/need-triage Team needs to triage and take a first look

Comments

@joanneshen
Copy link

Not sure if anyone reported this before.

Before we upgraded spring-shell to 2.1.x (backward-incompatible one), we used to apply the following for tab completion:
public static class CustomCompleterAdapter extends CompleterAdapter {
@OverRide
public void complete(LineReader reader, ParsedLine line, List candidates) {
List oldCandidates = new ArrayList<>();
super.complete(reader, line, oldCandidates);
......// construct candidates based on oldCandidates
}

@bean
public CompleterAdapter myCompleter() {
CompleterAdapter result = new CustomCompleterAdapter();
result.setShell(shell);
return result;
}

However, after upgrade this is partially broken, which means the completion for command seemed fine, but not for the arguement. Any alternative way to use this kind of generic way to achieve tab completion?
In the meantime also try to use the way of annotating ValueProvider for command options, but that is also not fully working (refer to issue #923).

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Oct 23, 2024
@joanneshen joanneshen changed the title After upgrade spring-shell from 2.0.1 to 2.1.7 Tab Completion partially not working anymore After upgrade spring-shell from 2.0.1 to 2.1.7 Tab Completion not working anymore Oct 23, 2024
@corneil
Copy link

corneil commented Oct 28, 2024

Spring Shell 2.1.x has been out of support since 2023-11-28.
If you are on Commercial support please log a ticket via the customer support desk.
I suggest you upgrade to at least 3.2.x or later.

@corneil corneil closed this as completed Oct 28, 2024
@joanneshen
Copy link
Author

Sorry, I should have said that that the system is migrated/upgraded to spring-shell 3.3.3. Still the same issue. Thanks!

@joanneshen joanneshen changed the title After upgrade spring-shell from 2.0.1 to 2.1.7 Tab Completion not working anymore After upgrade spring-shell from 2.0.1 to 2.1.x then to 3.3.x Tab Completion not working anymore Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

No branches or pull requests

2 participants