Skip to content

Commit 9e58651

Browse files
committed
[GHA] Add tag parameter to vscode release job for testing purposes
1 parent 2b42234 commit 9e58651

File tree

2 files changed

+22
-15
lines changed

2 files changed

+22
-15
lines changed

Diff for: .github/scripts/build-vscode-extension.sh

+12-12
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,18 @@ fi
3939

4040
# for release build we don't add version-qualifier to package.json
4141
# So we must instead rename the file ourself to add a qualifier
42-
if [ "$dist_type" == release ]; then
43-
vsix_file=`ls *.vsix`
44-
git fetch --tags
45-
release_name=`git tag --points-at HEAD | grep ${extension_id}`
46-
echo "release_name=$release_name"
47-
if [ -z "$release_name" ]; then
48-
echo "Release Candidates must be tagged" >&2
49-
exit 1
50-
else
51-
mv $vsix_file ${release_name}.vsix
52-
fi
53-
fi
42+
#if [ "$dist_type" == release ]; then
43+
# vsix_file=`ls *.vsix`
44+
# git fetch --tags
45+
# release_name=`git tag --points-at HEAD | grep ${extension_id}`
46+
# echo "release_name=$release_name"
47+
# if [ -z "$release_name" ]; then
48+
# echo "Release Candidates must be tagged" >&2
49+
# exit 1
50+
# else
51+
# mv $vsix_file ${release_name}.vsix
52+
# fi
53+
#fi
5454

5555
mkdir -p $workdir/vsix
5656
cp *.vsix $workdir/vsix

Diff for: .github/workflows/release-vscode-extension.yml

+10-3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ on:
1111
description: For example "RC1"
1212
required: true
1313
type: string
14+
tag:
15+
description: tag the git repo if value is 'true'
16+
required: true
17+
type: boolean
1418

1519
permissions:
1620
contents: write
@@ -34,16 +38,19 @@ jobs:
3438
id: version
3539
run: |
3640
base_version=`jq -r .version vscode-extensions/${{ inputs.extension-name }}/package.json`
41+
release_name=${{ inputs.extension-name }}-${{ steps.version.outputs.version }}-${{ inputs.postfix }}
3742
echo "Version: ${base_version}"
3843
echo "version=$base_version" >> $GITHUB_OUTPUT
44+
echo "release_name=$release_name" >> $GITHUB_OUTPUT
3945
- name: Create tag
46+
if: ${{ inputs.tag }}
4047
uses: actions/github-script@v7
4148
with:
4249
script: |
4350
github.rest.git.createRef({
4451
owner: context.repo.owner,
4552
repo: context.repo.repo,
46-
ref: 'refs/tags/${{ inputs.extension-name }}-${{ steps.version.outputs.version }}-${{ inputs.postfix }}',
53+
ref: 'refs/tags/${{ steps.version.outputs.release_name }}',
4754
sha: context.sha
4855
})
4956
- name: Set up JDK 17
@@ -64,8 +71,8 @@ jobs:
6471
s3_path=release/vscode-extensions/${{ inputs.extension-name }}/${{ steps.version.outputs.version }}
6572
echo "S3 path: ${s3_path}"
6673
aws s3 rm s3://$AWS_S3_BUCKET/$s3_path/ --recursive
67-
aws s3 cp ./vsix/$vsix_file s3://$AWS_S3_BUCKET/$s3_path/$vsix_file --no-progress
68-
echo "s3_url=${DOWNLOAD_URL_ROOT}/$s3_path/$vsix_file" >> $GITHUB_OUTPUT
74+
aws s3 cp ./vsix/$vsix_file s3://$AWS_S3_BUCKET/$s3_path/${{ steps.version.outputs.release_name }}.vsix --no-progress
75+
echo "s3_url=${DOWNLOAD_URL_ROOT}/$s3_path/${{ steps.version.outputs.release_name }}.vsix" >> $GITHUB_OUTPUT
6976
- id: tools-team-slack
7077
uses: slackapi/[email protected]
7178
env:

0 commit comments

Comments
 (0)