Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly deal with concatenated values in annotation attributes #1463

Closed
martinlippert opened this issue Feb 3, 2025 · 1 comment
Closed

correctly deal with concatenated values in annotation attributes #1463

martinlippert opened this issue Feb 3, 2025 · 1 comment
Assignees
@martinlippert
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Milestone
4.29.0.RELEASE

Comments

@martinlippert
Copy link
Member

Extracting string values from annotation attributes should take concatenated strings into account, incl. constants.

Examples are:

  • @Component bean names, @Bean names
  • @RequestMapping path extraction
  • and probably many more

Code around this needs to be refactored to avoid code duplication as well.
@martinlippert martinlippert added for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement labels Feb 3, 2025
@martinlippert martinlippert added this to the 4.29.0.RELEASE milestone Feb 3, 2025
@martinlippert martinlippert self-assigned this Feb 3, 2025
martinlippert added a commit that referenced this issue Feb 6, 2025
@martinlippert
GH-1463: support concatenated strings while extracting request mappin…
c28c6d8 
…g path information
martinlippert added a commit that referenced this issue Feb 7, 2025
@martinlippert
GH-1463: additional test cases for concatenated bean names in compone…
0851877 
…nt annotations
martinlippert added a commit that referenced this issue Feb 7, 2025
@martinlippert
GH-1463: support concatenated strings added to beans symbol provider
ba9a589
martinlippert added a commit that referenced this issue Feb 7, 2025
@martinlippert
GH-1463: support for concatenated strings added to qualifier referenc…
b3c7e7f 
…e provider
martinlippert added a commit that referenced this issue Feb 10, 2025
@martinlippert
GH-1463: support for concatenated strings for more reference providers
f96b32b
martinlippert added a commit that referenced this issue Feb 11, 2025
@martinlippert
GH-1463: added test case for string concatenation with request mappin…
27f4456 
…gs from parent classes
martinlippert added a commit that referenced this issue Feb 11, 2025
@martinlippert
GH-1463: added test case for string concatenation with request mappin…
da0a8b8 
…gs from parent classes with attribute names
@martinlippert martinlippert mentioned this issue Feb 27, 2025
Open
@martinlippert
Copy link
Member Author

Closing this item for the upcoming 4.29.0 release with all the work that has gone into this. Work on this continues for the 4.30.0 release via #1486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlippert martinlippert

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Projects
None yet
Milestone
4.29.0.RELEASE
Development

No branches or pull requests
1 participant
@martinlippert