Merge branch 'feature/3778-squiz-lowercasephpfunctions-bugfix' of https://github.com/jrfnl/PHP_CodeSniffer

Author: gsherwood

src/Standards/Generic/Sniffs/PHP/ForbiddenFunctionsSniff.php

@@ -163,6 +163,11 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
+        if (empty($tokens[$stackPtr]['nested_attributes']) === false) {
+            // Class instantiation in attribute, not function call.
+            return;
+        }
+
         $function = strtolower($tokens[$stackPtr]['content']);
         $pattern  = null;
 

src/Standards/Generic/Tests/PHP/ForbiddenFunctionsUnitTest.inc

@@ -55,3 +55,6 @@ function mymodule_form_callback(SizeOf $sizeof) {
 }
 
 $size = $class?->sizeof($array);
+
+#[SizeOf(10)]
+function doSomething() {}

src/Standards/Squiz/Sniffs/PHP/LowercasePHPFunctionsSniff.php

@@ -75,6 +75,11 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         // Make sure this is a function call or a use statement.
+        if (empty($tokens[$stackPtr]['nested_attributes']) === false) {
+            // Class instantiation in attribute, not function call.
+            return;
+        }
+
         $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($stackPtr + 1), null, true);
         if ($next === false) {
             // Not a function call.

src/Standards/Squiz/Tests/PHP/DiscouragedFunctionsUnitTest.inc

@@ -2,4 +2,6 @@
 error_log('test');
 print_r($array);
 var_dump($array);
-?>
+
+#[Var_Dump(10)]
+function debugMe() {}

src/Standards/Squiz/Tests/PHP/LowercasePHPFunctionsUnitTest.inc

@@ -41,3 +41,10 @@ $callToNamespacedFunction = namespace\STR_REPEAT($a, 2); // Could potentially be
 $filePath = new \File($path);
 
 $count = $object?->Count();
+
+class AttributesShouldBeIgnored
+{
+    #[Putenv('FOO', 'foo')]
+    public function foo(): void
+    {}
+}

src/Standards/Squiz/Tests/PHP/LowercasePHPFunctionsUnitTest.inc.fixed

@@ -41,3 +41,10 @@ $callToNamespacedFunction = namespace\STR_REPEAT($a, 2); // Could potentially be
 $filePath = new \File($path);
 
 $count = $object?->Count();
+
+class AttributesShouldBeIgnored
+{
+    #[Putenv('FOO', 'foo')]
+    public function foo(): void
+    {}
+}