Skip to content

Fixed drive switching on windows #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 24, 2024
Merged

Fixed drive switching on windows #341

merged 20 commits into from
Apr 24, 2024

Conversation

mbwilding
Copy link
Contributor

@mbwilding mbwilding commented Mar 30, 2024

Proposed fix for the traversal part of issue #326

@mbwilding mbwilding changed the title Fixed drive browsing on windows Fixed drive switching on windows Mar 30, 2024
@mbwilding
Copy link
Contributor Author

mbwilding commented Mar 30, 2024

I am currently looking into how to fix browsing network mapped drives.

EDIT1: turns out we can traverse mapped drives, but still finding the right place to apply the fix.
EDIT2: Sorted out mapped/network drives

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions

@github-actions github-actions bot requested a review from stevearc April 14, 2024 02:15
@mbwilding
Copy link
Contributor Author

mbwilding commented Apr 14, 2024

All the tests are passing on my fork now.
I put that addslash back in but added a check for \\ in that function instead.

EDIT: Just saw your other comment, fixing that now.

@mbwilding
Copy link
Contributor Author

mbwilding commented Apr 14, 2024

I tried the early return, but it needs the logic below that does checks like if it is a directory or not then adjusts the path. It just throws buffer errors otherwise.

Top section just handles the drive select logic.

@stevearc
Copy link
Owner

I'm surprised by the presence of backslashes in certain locations. I'm going to need to pull this locally and poke around a bit, but I don't have a windows machine with me at the moment. Will follow up on this next week.

@stevearc
Copy link
Owner

@mbwilding okay, I think I have a better fix for the double \\ when opening oil with nvim .. LMK what you think

@mbwilding
Copy link
Contributor Author

mbwilding commented Apr 24, 2024

@stevearc Your changes work as expected, I like it.
Tested mapped drives and local, as well as nvim .
LGTM.

@stevearc stevearc merged commit f3a31eb into stevearc:master Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants