-
Notifications
You must be signed in to change notification settings - Fork 152
Fixed drive switching on windows #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am currently looking into how to fix browsing network mapped drives. EDIT1: turns out we can traverse mapped drives, but still finding the right place to apply the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions
All the tests are passing on my fork now. EDIT: Just saw your other comment, fixing that now. |
I tried the early return, but it needs the logic below that does checks like if it is a directory or not then adjusts the path. It just throws buffer errors otherwise. Top section just handles the drive select logic. |
I'm surprised by the presence of backslashes in certain locations. I'm going to need to pull this locally and poke around a bit, but I don't have a windows machine with me at the moment. Will follow up on this next week. |
@mbwilding okay, I think I have a better fix for the double |
@stevearc Your changes work as expected, I like it. |
Proposed fix for the traversal part of issue #326