Skip to content

refactor: move loading message delay to config #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: move loading message delay to config #424

wants to merge 1 commit into from

Conversation

kevintraver
Copy link
Contributor

This allows loading_message_delay to be overridden

@github-actions github-actions bot requested a review from stevearc June 18, 2024 22:38
@stevearc
Copy link
Owner

In general I want to avoid exposing additional options in the config unless they are necessary. The list of options is already quite large, and it makes it hard for users to find what they're looking for. Could you describe the issue you are trying to solve with this, and why this is necessary?

@kevintraver
Copy link
Contributor Author

kevintraver commented Jun 19, 2024

I sometimes see the loading indicator flash, and would like to set it to a higher value.

Maybe this can be something thats not in config by default, but still in the docs and can be added manually.

@stevearc
Copy link
Owner

What is a value that would cause it to not flicker for you? 100ms was pulled from nowhere in particular, and I'm probably fine with any number below 500ms. I wouldn't even blink at bumping to 200ms.

@kevintraver
Copy link
Contributor Author

Yeah, it does not flicker at 200ms.

@stevearc
Copy link
Owner

Delay updated to 200ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants