-
Notifications
You must be signed in to change notification settings - Fork 34
improve fix
messages
#276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd be happy to take a stab at this one, in the interest of finishing what I started in #264. |
Sure, go right ahead! If you want to just focus on the I think the goal is to supply "corrected" code whenever possible. That is more straightforward for some rules than others, so the scope of this PR can be up to you. |
@a-frantz Hi! I noticed this issue is still marked as open. Is it still available to work on? |
There are probably some improvements we can make to our |
This issue is the successor of #193
#260 ensured that every lint diagnostic includes a
fix
message, however some of them are still lacking. We should take another pass and include "corrected" code snippets wherever possible.#264 (adds
ShellCheck
) uses the samefix
message for every diagnostic. SC does provide its own "fix" for some diagnostics (but not all). It would be great if we could "translate" the SC fixes into our own fix messages.The text was updated successfully, but these errors were encountered: