Skip to content

Sync MatchingParameterMeta and InputSorting fix messages #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adthrasher opened this issue Mar 31, 2025 · 4 comments
Open

Sync MatchingParameterMeta and InputSorting fix messages #379

adthrasher opened this issue Mar 31, 2025 · 4 comments
Labels
enhancement New feature or request S-blocked State: blocked on an external change or decision

Comments

@adthrasher
Copy link
Member

adthrasher commented Mar 31, 2025

Currently, if the input block is out-of-order and the parameter_meta block does not match this order, the user gets two conflicting messages about ordering. Both lints should use the same correct ordering in their "fix" message. The logic should be abstracted and probably belongs in wdl-format.

The current logic for sorting input block declaration is contained in wdl-lint here.

Before this issue can be resolved, there will need to be architectural changes as wdl-format is not currently exposed to wdl-lint. This will be a non-trivial change and will likely need some discussion within the team to get the desired implementation direction.

@adthrasher adthrasher changed the title Update MatchingParameterMeta fix message Sync MatchingParameterMeta and InputSorting fix messages Mar 31, 2025
@Gyan-max
Copy link
Contributor

Hi @adthrasher Should the fix messages follow a strict input block order, or should they allow some flexibility based on context?

@Gyan-max
Copy link
Contributor

Also, should the fix messages suggest a strict reordering or just highlight the mismatch for the user to resolve?

@adthrasher adthrasher added enhancement New feature or request S-blocked State: blocked on an external change or decision labels Mar 31, 2025
@adthrasher
Copy link
Member Author

@Gyan-max - I have updated the original comment with additional details. At this point, this issue is blocked waiting on other changes.

@Gyan-max
Copy link
Contributor

@adthrasher,

Thanks for the update! I'll keep an eye on the related changes. Let me know if there's anything I can help with once this is unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request S-blocked State: blocked on an external change or decision
Projects
None yet
Development

No branches or pull requests

2 participants