Skip to content

Commit cc32d7c

Browse files
committed
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add BUILD_REGISTRY option to our build mechanism
Signed-off-by: Jakub Stejskal <[email protected]>
1 parent d664f8c commit cc32d7c

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

.github/actions/build-strimzi-binaries/action.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ runs:
3131
uses: actions/cache@v4
3232
with:
3333
path: ~/.m2/repository
34-
key: "maven-cache | ${{ github.job }} | **/pom.xml"
34+
key: "maven-cache | ${{ github.run_id }} | **/pom.xml"
3535
restore-keys: |
36-
maven | ${{ github.job }}
36+
maven | ${{ github.run_id }}
3737
maven
3838
- name: Cache Kafka binaries
3939
uses: actions/cache@v4

.github/actions/containers-load/action.yml

+2-8
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,8 @@ runs:
2424

2525
- name: Load Strimzi images
2626
shell: bash
27-
# TODO - check if eval is really needed?
28-
# eval $(minikube docker-env)
2927
run: |
30-
make docker_load
31-
make docker_tag
32-
make docker_push
33-
docker images -a
34-
make docker_amend_manifest docker_delete_archive
35-
docker images -a
28+
eval $(minikube docker-env)
29+
make docker_load docker_tag docker_push docker_create_manifest docker_delete_archive
3630
env:
3731
DOCKER_ARCHITECTURE: ${{ inputs.architecture }}

.github/actions/containers-push-manifest/action.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ runs:
66
steps:
77
- name: Push containers manifest
88
shell: bash
9-
# TODO - check if eval is really needed
10-
# eval $(minikube docker-env)
119
run: |
10+
eval $(minikube docker-env)
1211
make docker_push_manifest

Makefile.docker

+5
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,11 @@ docker_amend_manifest_default:
6868
# Create / Amend the manifest
6969
$(DOCKER_CMD) manifest create $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$(PROJECT_NAME):$(DOCKER_TAG) --amend $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$(PROJECT_NAME):$(DOCKER_TAG)$(DOCKER_PLATFORM_TAG_SUFFIX)
7070

71+
.PHONY: docker_create_manifest_default
72+
docker_create_manifest_default:
73+
# Create the manifest (CI only - TODO - maybe revert?)
74+
$(DOCKER_CMD) manifest create $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$(PROJECT_NAME):$(DOCKER_TAG) $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$(PROJECT_NAME):$(DOCKER_TAG)$(DOCKER_PLATFORM_TAG_SUFFIX)
75+
7176
.PHONY: docker_push_manifest_default
7277
docker_push_manifest_default:
7378
# Push the manifest to the registry

0 commit comments

Comments
 (0)