Skip to content

Commit 02ae7fc

Browse files
fix: upload doesn't close file handle (#323)
1 parent 84cbe47 commit 02ae7fc

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

storage3/_async/file_api.py

+4
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ async def _request(
5151
resp = exc.response.json()
5252
raise StorageApiError(resp["message"], resp["error"], resp["statusCode"])
5353

54+
# close the resource before returning the response
55+
if files and "file" in files and isinstance(files["file"][1], BufferedReader):
56+
files["file"][1].close()
57+
5458
return response
5559

5660
async def create_signed_upload_url(self, path: str) -> SignedUploadURL:

storage3/_sync/file_api.py

+4
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ def _request(
5151
resp = exc.response.json()
5252
raise StorageApiError(resp["message"], resp["error"], resp["statusCode"])
5353

54+
# close the resource before returning the response
55+
if files and "file" in files and isinstance(files["file"][1], BufferedReader):
56+
files["file"][1].close()
57+
5458
return response
5559

5660
def create_signed_upload_url(self, path: str) -> SignedUploadURL:

0 commit comments

Comments
 (0)