fix: add generic max calcutation composable

Author: akalogerakisunicorn

src/protocols/ethereum/composables/ethMaxAmount.ts renamed to src/composables/coinMaxAmount.ts

@@ -7,23 +7,25 @@ import {
   useBalances,
 } from '@/composables';
 import { ProtocolAdapterFactory } from '@/lib/ProtocolAdapterFactory';
-import { PROTOCOLS } from '@/constants';
 import { toShiftedBigNumber } from '@/utils';
 
-interface EthMaxAmountOptions extends MaxAmountOptions {
+interface CoinMaxAmountOptions extends MaxAmountOptions {
   fee: Ref<BigNumberPublic>;
 }
 
 /**
  * Composable that allows to use real max amount of selected token
  * considering the fee that needs to be paid.
  */
-export function useEthMaxAmount({ formModel, fee }: EthMaxAmountOptions) {
+export function useCoinMaxAmount({ formModel, fee }: CoinMaxAmountOptions) {
   const { balance } = useBalances();
 
-  const isEthCoin = computed(() => {
-    const ethAdapter = ProtocolAdapterFactory.getAdapter(PROTOCOLS.ethereum);
-    return formModel.value?.selectedAsset?.contractId === ethAdapter.coinContractId;
+  const isCoin = computed(() => {
+    if (!formModel.value.selectedAsset?.protocol) {
+      return false;
+    }
+    const adapter = ProtocolAdapterFactory.getAdapter(formModel.value.selectedAsset?.protocol!);
+    return formModel.value?.selectedAsset?.contractId === adapter.coinContractId;
   });
   const selectedTokenBalance = computed(
     () => new BigNumber(
@@ -35,8 +37,11 @@ export function useEthMaxAmount({ formModel, fee }: EthMaxAmountOptions) {
   );
 
   const max = computed(() => {
-    if (balance.value && isEthCoin.value) {
-      const maxAmount = balance.value.minus(fee.value);
+    if (balance.value && isCoin.value) {
+      const maxAmount = balance.value
+        .minus(fee.value)
+        .dividedBy(formModel.value.addresses?.length || 1)
+        .decimalPlaces(formModel.value.selectedAsset?.decimals!);
       return (maxAmount.isPositive() ? maxAmount : 0).toString();
     }
     return selectedTokenBalance.value.toString();

src/protocols/bitcoin/components/TransferSendForm.vue

@@ -42,8 +42,8 @@
       >
         <template #label-after>
           <BtnMaxAmount
-            :is-max="formModel?.amount?.toString() === max.toString()"
-            @click="setMaxAmount"
+            :is-max="shouldUseMaxAmount"
+            @click="toggleMaxAmount"
           />
         </template>
       </TransferSendAmount>
@@ -88,6 +88,7 @@ import {
   useNetworks,
 } from '@/composables';
 import { useTransferSendForm } from '@/composables/transferSendForm';
+import { useCoinMaxAmount } from '@/composables/coinMaxAmount';
 import { NETWORK_TYPE_TESTNET, PROTOCOLS } from '@/constants';
 import {
   executeAndSetInterval,
@@ -141,6 +142,7 @@ export default defineComponent({
 
     const hasMultisigTokenWarning = ref(false);
     const isUrlTippingEnabled = ref(false);
+    const shouldUseMaxAmount = ref(false);
 
     const {
       formModel,
@@ -172,7 +174,8 @@ export default defineComponent({
     ));
 
     const numericFee = computed(() => +fee.value.toFixed());
-    const max = computed(() => balance.value.minus(fee.value));
+
+    const { max } = useCoinMaxAmount({ formModel, fee });
 
     function emitCurrentFormModelState() {
       const inputPayload: TransferFormModel = {
@@ -194,8 +197,11 @@ export default defineComponent({
       }
     }
 
-    function setMaxAmount() {
-      formModel.value.amount = max.value.isPositive() ? max.value.toString() : '0';
+    function toggleMaxAmount() {
+      shouldUseMaxAmount.value = !shouldUseMaxAmount.value;
+      if (shouldUseMaxAmount.value) {
+        formModel.value.amount = max.value;
+      }
     }
 
     async function updateFeeList() {
@@ -257,6 +263,15 @@ export default defineComponent({
       }
     });
 
+    watch(
+      max,
+      (newMax) => {
+        if (shouldUseMaxAmount.value) {
+          formModel.value.amount = newMax;
+        }
+      },
+    );
+
     watch(
       hasError,
       (val) => emit('error', val),
@@ -291,10 +306,11 @@ export default defineComponent({
       balance,
       max,
       clearPayload,
+      shouldUseMaxAmount,
       scanTransferQrCode,
       handleAssetChange,
       submit,
-      setMaxAmount,
+      toggleMaxAmount,
       toBitcoin,
     };
   },

src/protocols/ethereum/components/TransferSendForm.vue

@@ -87,6 +87,7 @@ import {
 } from '@/composables';
 import { useEthFeeCalculation } from '@/protocols/ethereum/composables/ethFeeCalculation';
 import { useTransferSendForm } from '@/composables/transferSendForm';
+import { useCoinMaxAmount } from '@/composables/coinMaxAmount';
 import { NETWORK_TYPE_TESTNET, PROTOCOLS } from '@/constants';
 import { executeAndSetInterval } from '@/utils';
 import { ProtocolAdapterFactory } from '@/lib/ProtocolAdapterFactory';
@@ -95,7 +96,6 @@ import {
   ETH_COIN_SYMBOL,
   ETH_PROTOCOL_NAME,
 } from '@/protocols/ethereum/config';
-import { useEthMaxAmount } from '@/protocols/ethereum/composables/ethMaxAmount';
 import { useEthNetworkSettings } from '@/protocols/ethereum/composables/ethNetworkSettings';
 import { getTokenTransferGasLimit } from '@/protocols/ethereum/helpers';
 
@@ -173,7 +173,7 @@ export default defineComponent({
 
     const shouldUseMaxAmount = ref(false);
 
-    const { max } = useEthMaxAmount({ formModel, fee: maxFee });
+    const { max } = useCoinMaxAmount({ formModel, fee: maxFee });
 
     const numericFee = computed(() => +fee.value.toFixed());
     const numericMaxFee = computed(() => +maxFee.value.toFixed());