Skip to content

Improve pagination include #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bewuethr opened this issue Mar 18, 2023 · 0 comments · Fixed by #181
Closed

Improve pagination include #180

bewuethr opened this issue Mar 18, 2023 · 0 comments · Fixed by #181
Assignees

Comments

@bewuethr
Copy link
Member

In #176, the paginator include has been modified to not rely on any legacy paginate-v1 settings, enabling pagination of multiple collections.

The trail is still rather ugly, muddling together permalinks and replacing numbers; a nicer solution would be to leverage the paginator.page_trail. An example of an implementation can be found in mmistakes/minimal-mistakes#2636; notice the issues with the redundant index.html being appended.

While we're at it, whitespace could also do with a cleanup.

@bewuethr bewuethr converted this from a draft issue Mar 18, 2023
@bewuethr bewuethr self-assigned this Mar 18, 2023
@bewuethr bewuethr moved this from 🟡 Backlog to 🙂 Todo in Swiss Club website Mar 18, 2023
@bewuethr bewuethr moved this from 🙂 Todo to 🤔 In Progress in Swiss Club website Mar 18, 2023
@bewuethr bewuethr linked a pull request Mar 18, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🤔 In Progress to 🥳 Done in Swiss Club website Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

1 participant