File tree Expand file tree Collapse file tree 2 files changed +4
-4
lines changed Expand file tree Collapse file tree 2 files changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -787,7 +787,7 @@ class Encore {
787
787
* // change the babelConfig
788
788
* // if you use an external Babel configuration
789
789
* // this callback will NOT be used. In this case
790
- * // you can pass false as the first parameter to
790
+ * // you can pass null as the first parameter to
791
791
* // still be able to use some of the options below
792
792
* // without a warning.
793
793
* }, {
@@ -833,7 +833,7 @@ class Encore {
833
833
* file for instance). In this case you can set the option directly into
834
834
* that configuration file.
835
835
*
836
- * @param {function|false } callback
836
+ * @param {function|null } callback
837
837
* @param {object } encoreOptions
838
838
* @returns {Encore }
839
839
*/
Original file line number Diff line number Diff line change @@ -621,14 +621,14 @@ describe('WebpackConfig object', () => {
621
621
it ( 'Calling with a whitelisted option when .babelrc is present works fine' , ( ) => {
622
622
const config = createConfig ( ) ;
623
623
config . runtimeConfig . babelRcFileExists = true ;
624
- config . configureBabel ( false , { includeNodeModules : [ 'foo' ] } ) ;
624
+ config . configureBabel ( null , { includeNodeModules : [ 'foo' ] } ) ;
625
625
expect ( logger . getMessages ( ) . warning ) . to . be . empty ;
626
626
} ) ;
627
627
628
628
it ( 'Calling with a non-whitelisted option when .babelrc is present displays a warning' , ( ) => {
629
629
const config = createConfig ( ) ;
630
630
config . runtimeConfig . babelRcFileExists = true ;
631
- config . configureBabel ( false , { useBuiltIns : 'foo' } ) ;
631
+ config . configureBabel ( null , { useBuiltIns : 'foo' } ) ;
632
632
633
633
const warnings = logger . getMessages ( ) . warning ;
634
634
expect ( warnings ) . to . have . lengthOf ( 1 ) ;
You can’t perform that action at this time.
0 commit comments