-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add git prompt #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add git prompt #130
Conversation
* Moved where the node18 warning shows up Also adjusted the default install if people have node18 installed Readded the --version flag * Using the consts.TITLE_TEXT inside renderTitle func
Also point the PR to main |
Hey @juliusmarminge thanks for the comments, first time doing an open source PR. |
@juliusmarminge updated PR to main, also fixed requested changes (added related message) Changed PR via the edit tool hope this didn't cause issues |
Not sure why husky isnt formatting precommit for you? |
All good. Thats why we added the CI to get the verification before merge. Every commit doesnt have to be perfect |
Thanks for being understanding! Wasn't a lot of code but this my first non readme PR to open source. Updated PR to match template format. @juliusmarminge should I resolve a conversation or leave that to the maintainers? |
Add git prompt
In #128 @juliusmarminge suggested adding a git init prompt to choose if you wish to init a git repo.
Skips if noGit flag is already passed.
Screenshots
💯