feat: add db.sqlite to gitignore #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
nexxeln
requested changes
Jul 16, 2022
nexxeln
approved these changes
Jul 16, 2022
|
Cool thanks! |
korawit-dvtx
pushed a commit
to korawit-dvtx/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
* feat: add db.sqlite to gitignore * fix: db path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add db.sqlite to gitignore
[Short summary/description of story/feature/bugfix]
As mentioned in #200, the
db.sqlitefile created by the default prisma config was not included in .gitignore.I believe it's better to include it - Because we're not automatically creating a 'project initialized commit', it's easy to overlook the db file among all the other files that exist in version history after you initialize the app, and accidentally commit it.
If desired this could be changed to only include that line in the .gitignore if prisma is selected during initialization, but this way is much simpler and personally I think don't think it's an issue to just include it in .gitignore for everyone.
💯