chore: additional tests

Author: tandemdude

linkd/conditions.py

@@ -48,7 +48,7 @@ class BaseCondition(abc.ABC):
 
     def __init__(self, inner: type[t.Any] | types.UnionType | tuple[t.Any, ...] | None) -> None:
         if isinstance(inner, tuple) or inner is None or t.get_origin(inner) in (types.UnionType, t.Union):
-            raise SyntaxError(f"{self.__class__.__name__!r} can only be parameterized by concrete types")
+            raise ValueError(f"{self.__class__.__name__!r} can only be parameterized by concrete types")
 
         if compose._is_compose_class(inner):
             raise ValueError(f"{self.__class__.__name__!r} cannot be parameterized by composed types")

tests/test_compose.py

@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2025-present tandemdude
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+import linkd
+
+
+class TestCompose:
+    def test_compose_generates_working_class(self) -> None:
+        class Deps(linkd.Compose):
+            foo: str
+            bar: int
+
+        d = Deps("foo", 1234)
+        assert d.foo == "foo"
+        assert d.bar == 1234

tests/test_conditions.py

@@ -0,0 +1,48 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2025-present tandemdude
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+import pytest
+
+import linkd
+
+
+class Deps(linkd.Compose):
+    foo: str
+    bar: int
+
+
+class TestBaseCondition:
+    def test_cannot_instantiate_with_composite_type(self) -> None:
+        with pytest.raises(ValueError):
+            linkd.If(int | str)  # type: ignore[reportCallIssue]
+
+    def test_cannot_instantiate_with_composed_type(self) -> None:
+        with pytest.raises(ValueError):
+            linkd.If(Deps)  # type: ignore[reportCallIssue]
+
+
+class TestDependencyExpression:
+    def test_cannot_create_from_composed_type(self) -> None:
+        with pytest.raises(ValueError):
+            linkd.DependencyExpression.create(Deps)
+
+    def test_cannot_create_from_composed_union(self) -> None:
+        with pytest.raises(ValueError):
+            linkd.DependencyExpression.create(Deps | None)

tests/test_solver.py

@@ -26,6 +26,7 @@
 import linkd
 from linkd import solver
 from linkd.solver import CANNOT_INJECT
+from linkd.solver import _parse_composed_dependencies
 from linkd.solver import _parse_injectable_params
 
 COMMAND_CONTEXT = linkd.global_context_registry.register("linkd.contexts.command")
@@ -81,6 +82,22 @@ def m(foo: str, bar: int = linkd.INJECTED, *, baz: float, bork: bool = linkd.INJ
         assert kw["bork"]._order[0].inner is bool and kw["bork"]._required
 
 
+class TestComposedTypeParsing:
+    def test_parses_composed_type_correctly(self) -> None:
+        class Deps(linkd.Compose):
+            foo: str
+            bar: int
+
+        deps = _parse_composed_dependencies(Deps)
+
+        assert len(deps) == 2
+        assert "foo" in deps and "bar" in deps
+
+    def test_errors_for_non_composed_type(self) -> None:
+        with pytest.raises(TypeError):
+            _parse_composed_dependencies(int)  # type: ignore[reportArgumentType]
+
+
 class TestMethodInjection:
     @pytest.mark.asyncio
     async def test_exception_raised_when_no_context_available(self) -> None:
@@ -248,6 +265,24 @@ def m(foo, obj: object = linkd.INJECTED) -> None:  # type: ignore[reportUnknownP
         async with manager.enter_context(linkd.Contexts.ROOT):
             await m("bar")
 
+    @pytest.mark.asyncio
+    async def test_composed_dependency_provided_correctly(self) -> None:
+        class Deps(linkd.Compose):
+            foo: str
+            bar: int
+
+        manager = linkd.DependencyInjectionManager()
+        manager.registry_for(linkd.Contexts.ROOT).register_value(str, "foo")
+        manager.registry_for(linkd.Contexts.ROOT).register_value(int, 1234)
+
+        @linkd.inject
+        async def m(d: Deps = linkd.INJECTED) -> None:
+            assert d.foo == "foo"
+            assert d.bar == 1234
+
+        async with manager.enter_context(linkd.Contexts.ROOT):
+            await m()
+
 
 class TestDependencyInjectionManager:
     @pytest.mark.asyncio