-
Notifications
You must be signed in to change notification settings - Fork 19
Intl.NumberFormat support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @sffc |
Maybe this mismatch goes away if BigDecimals are always normalized? The main difference would be in how the default is treated: BigDecimals should omit rounding by default, I think, not round on Number's terms. If rounding options are used explicitly, then great, no mismatch. |
I think it would be reasonable if BigDecimal had a different default rounding strategy than Number (or BigInteger), but it should still allow Intl.NumberFormat to apply its own rounding. For example, when rendering a currency, you should obey the currency rounding rules. |
Given some discussions from the past few months, I'm thinking that maybe we should make I have been convinced that, for localization/display purposes, the precision is important and should be explicit somehow, either as |
I agree with @nicolo-ribaudo, in the sense that a "point on a number line" is a machine concept and not intrinsically a localizable value. It is localizable after the scale of the value is specified. I could still be convinced that we should treat normalized decimals the same as (normalized) floats to make things like migrating code bases easier. But this seems like something easy to add later when we have more evidence. |
It seems like
Intl.NumberFormat.prototype.format
should support BigDecimal transparently, just as it supports BigInt.On the ICU level, this should be straightforward, using the same API as BigInt uses.
On a function API level, we have clear precedent with BigInt that we should overload the
format
andformatToParts
methods.The complexity comes in for options processing: NumberFormat is based on rounding the input, but BigDecimal is all about avoiding implicit rounding. How should that all be handled?
The text was updated successfully, but these errors were encountered: