fix: Typing / Linting Errors

The code base was ported from python2 on a whim, and a lot of the code
reflects that. This tidies up the typing and linting a little more

Author: techman83

filament_scale_enhanced/__init__.py

@@ -1,16 +1,15 @@
 # coding=utf-8
 from __future__ import absolute_import
 
-import flask
 import octoprint.plugin
 
 from .fse_version import VERSION as __version__  # noqa: F401
 from .hx711 import HX711
 
 try:
-    import RPi.GPIO as GPIO
+    from RPi import GPIO
 except (ModuleNotFoundError, RuntimeError):
-    import Mock.GPIO as GPIO  # noqa: F401
+    from Mock import GPIO  # noqa: F401
 
 
 # pylint: disable=too-many-ancestors
@@ -26,27 +25,27 @@ class FilamentScalePlugin(
     tq = None
 
     @staticmethod
-    def get_template_configs():
-        return [dict(type="settings", custom_bindings=True)]
+    def get_template_configs():  # pylint: disable=arguments-differ
+        return [{"type": "settings", "custom_bindings": True}]
 
     @staticmethod
-    def get_settings_defaults():
-        return dict(
-            tare=8430152,
-            reference_unit=-411,
-            spool_weight=200,
-            clockpin=21,
-            datapin=20,
-            lastknownweight=0,
-        )
+    def get_settings_defaults():  # pylint: disable=arguments-differ
+        return {
+            "tare": 8430152,
+            "reference_unit": -411,
+            "spool_weight": 200,
+            "clockpin": 21,
+            "datapin": 20,
+            "lastknownweight": 0,
+        }
 
     @staticmethod
-    def get_assets():
-        return dict(
-            js=["js/filament_scale.js"],
-            css=["css/filament_scale.css"],
-            less=["less/filament_scale.less"],
-        )
+    def get_assets():  # pylint: disable=arguments-differ
+        return {
+            "js": ["js/filament_scale.js"],
+            "css": ["css/filament_scale.css"],
+            "less": ["less/filament_scale.less"],
+        }
 
     def __init__(self):
         super().__init__()
@@ -113,10 +112,10 @@ def check_weight(self):
             self.last_weight = v
             self._plugin_manager.send_plugin_message(self._identifier, v)
             self.hx.power_down()
-        except Exception as err:
+        except Exception as err:  # pylint: disable=broad-exception-caught
             self._logger.exception(err)
 
-    # pylint: disable=line-too-long
+    # pylint: disable=line-too-long,use-dict-literal
     def get_update_information(self):
         # Define the configuration for your plugin to use with the
         # Software Update Plugin here.

filament_scale_enhanced/hx711.py

@@ -2,9 +2,9 @@
 import statistics
 
 try:
-    import RPi.GPIO as GPIO
+    from RPi import GPIO
 except (ModuleNotFoundError, RuntimeError):
-    import Mock.GPIO as GPIO
+    from Mock import GPIO
 
 
 def bitsToBytes(a):

pytest.ini

@@ -1,3 +1,7 @@
 [pytest]
 python_files = tests/__init__.py
 addopts = -p no:cacheprovider --mypy --pylint --flake8
+filterwarnings =
+    ignore
+    default:::filament_scale.*
+    default:::tests.*

setup.py

@@ -4,7 +4,7 @@
 from setuptools import setup
 
 version = {}
-with open("filament_scale_enhanced/fse_version.py") as fp:
+with open("filament_scale_enhanced/fse_version.py", encoding="utf8") as fp:
     exec(fp.read(), version)  # pylint: disable=exec-used
 
 try:
@@ -38,7 +38,9 @@
         'pytest-pylint',
         'pylint',
         'pytest-flake8',
-        'Mock.GPIO'
+        'Mock.GPIO',
+        # Flake8 is likely a dead end
+        'flake8<5',
     ],
     'test': [
         'pytest',
@@ -47,7 +49,9 @@
         'pytest-pylint',
         'pylint',
         'pytest-flake8',
-        'Mock.GPIO'
+        'Mock.GPIO',
+        # Flake8 is likely a dead end
+        'flake8<5',
     ]
 }