Skip to content

Commit 6257020

Browse files
kanglanttensorflower-gardener
authored andcommitted
Add -oss_excluded to TF build/test tag filters
Currently, `no_oss` is used to exclude a test from running in the official TF OSS test infrastructure. However, it is difficult to distinguish between temporary and permanent exclusions. For example, a test may be disabled temporarily if it is broken, or it may be designed to not run on OSS permanently. To address this issue, we introduce a new tag `oss_excluded` for platform exclusion design. `no_oss` will now be considered to disable broken tests, while `oss_excluded` will be used to permanently exclude a test from running on OSS. PiperOrigin-RevId: 514847796
1 parent 9f1b18a commit 6257020

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

kokoro/github/ubuntu/cpu/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ TEST_ROOT=$(pwd)/${PIP_TEST_PREFIX}
3434
rm -rf "$TEST_ROOT"
3535
mkdir -p "$TEST_ROOT"
3636
ln -s "$(pwd)"/tensorflow_gnn "$TEST_ROOT"/tensorflow_gnn
37-
tag_filters="-no_oss"
37+
tag_filters="-no_oss,-oss_excluded"
3838

3939
bazel clean
4040
pip install -r requirements-dev.txt --progress-bar off

kokoro/github/ubuntu/cpu/build_versioned.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ ln -s "$(pwd)"/tensorflow_gnn "$TEST_ROOT"/tensorflow_gnn
4141
# Prepend common tag filters to a defined env_var
4242
# For example, tests for TF 2.8 shouldn't run RNG-dependent tests
4343
# These tag filters are enforced to start with a comma for separation
44-
tag_filters="-no_oss${TAG_FILTERS}"
44+
tag_filters="-no_oss,-oss_excluded${TAG_FILTERS}"
4545

4646
bazel clean
4747
pip install -r requirements-dev.txt --progress-bar off

tensorflow_gnn/docs/guide/developer.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,15 @@ After setting up the test directory, you can run all tests locally by running
8484
the following command in the repo root directory.
8585

8686
```
87-
bazel test --build_tag_filters=-no_oss --test_tag_filters=-no_oss --test_output=errors --verbose_failures=true --build_tests_only --define=no_tfgnn_py_deps=true --keep_going --experimental_repo_remote_exec //bazel_pip/tensorflow_gnn/...
87+
bazel test --build_tag_filters=-no_oss,-oss_excluded --test_tag_filters=-no_oss,-oss_excluded --test_output=errors --verbose_failures=true --build_tests_only --define=no_tfgnn_py_deps=true --keep_going --experimental_repo_remote_exec //bazel_pip/tensorflow_gnn/...
8888
```
8989

9090
The `--define=no_tfgnn_py_deps=true` flag directs bazel to assume that all
9191
dependencies are provided in the environment (where we just installed the .whl)
9292

93-
The flags `--build_tag_filters=-no_oss` and `--test_tag_filters=-no_oss` disable
94-
tests that pass in the internal production environment but fail on GitHub.
93+
The flags `--build_tag_filters=-no_oss,-oss_excluded` and
94+
`--test_tag_filters=-no_oss,-oss_excluded` disable tests that pass in the
95+
internal production environment but fail on GitHub.
9596

9697
### Run a single test file
9798

0 commit comments

Comments
 (0)