Bug Fix: Only override forceSvg from localStorage when the key is present (#5834)

rileyajones · web-flow · commit 39d1f53d7584 · 2022-08-02T09:14:06.000+07:00
only override forceSVG from localStorage when the key is present
diff --git a/tensorboard/webapp/feature_flag/effects/feature_flag_effects.ts b/tensorboard/webapp/feature_flag/effects/feature_flag_effects.ts
@@ -47,8 +47,8 @@ export class FeatureFlagEffects {
 
         if (features.forceSvg != null) {
           this.forceSvgDataSource.updateForceSvgFlag(features.forceSvg);
-        } else {
-          features.forceSvg = this.forceSvgDataSource.getForceSvgFlag();
+        } else if (this.forceSvgDataSource.getForceSvgFlag()) {
+          features.forceSvg = true;
         }
 
         return partialFeatureFlagsLoaded({features});

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ export class FeatureFlagEffects {`
`47`	`47`
`48`	`48`	`if (features.forceSvg != null) {`
`49`	`49`	`this.forceSvgDataSource.updateForceSvgFlag(features.forceSvg);`
`50`		`- } else {`
`51`		`- features.forceSvg = this.forceSvgDataSource.getForceSvgFlag();`
	`50`	`+ } else if (this.forceSvgDataSource.getForceSvgFlag()) {`
	`51`	`+ features.forceSvg = true;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`return partialFeatureFlagsLoaded({features});`