resolve comments - use tap instead of map, change action name

Author: roseayeon

tensorboard/webapp/metrics/actions/index.ts

@@ -272,8 +272,8 @@ export const metricsHideEmptyCardsToggled = createAction(
   '[Metrics] Hide Empty Cards Changed'
 );
 
-export const metricsUnresolvedPinnedCardsAdded = createAction(
-  '[Metrics] Unresolved Pinned Cards Added',
+export const metricsUnresolvedPinnedCardsFromLocalStorageAdded = createAction(
+  '[Metrics] Unresolved Pinned Cards From Local Storage Added',
   props<{cards: CardUniqueInfo[]}>()
 );
 

tensorboard/webapp/metrics/effects/index.ts

@@ -274,7 +274,7 @@ export class MetricsEffects implements OnInitEffects {
       ([, , enableGlobalPins, shouldPersistSettings]) =>
         enableGlobalPins && shouldPersistSettings
     ),
-    map(([{cardId, canCreateNewPins, wasPinned}, fetchInfos]) => {
+    tap(([{cardId, canCreateNewPins, wasPinned}, fetchInfos]) => {
       const card = fetchInfos.find((value) => value.id === cardId);
       // Saving only scalar pinned cards.
       if (!card || card.plugin !== PluginType.SCALARS) {
@@ -289,7 +289,8 @@ export class MetricsEffects implements OnInitEffects {
   );
 
   private readonly loadSavedPins$ = this.actions$.pipe(
-    ofType(initAction, coreActions.pluginsListingLoaded),
+    // Should be dispatch before stateRehydratedFromUrl.
+    ofType(initAction),
     withLatestFrom(
       this.store.select(selectors.getEnableGlobalPins),
       this.store.select(selectors.getShouldPersistSettings)
@@ -298,7 +299,7 @@ export class MetricsEffects implements OnInitEffects {
       ([, enableGlobalPins, shouldPersistSettings]) =>
         enableGlobalPins && shouldPersistSettings
     ),
-    map(() => {
+    tap(() => {
       const tags = this.savedPinsDataSource.getSavedScalarPins();
       if (!tags || tags.length === 0) {
         return;
@@ -308,7 +309,7 @@ export class MetricsEffects implements OnInitEffects {
         tag: tag,
       }));
       this.store.dispatch(
-        actions.metricsUnresolvedPinnedCardsAdded({
+        actions.metricsUnresolvedPinnedCardsFromLocalStorageAdded({
           cards: unresolvedPinnedCards,
         })
       );
@@ -353,7 +354,7 @@ export class MetricsEffects implements OnInitEffects {
          */
         this.addOrRemovePin$,
         /**
-         * Subscribes to: dashboard shown.
+         * Subscribes to: dashboard shown (initAction).
          */
         this.loadSavedPins$
       );

tensorboard/webapp/metrics/effects/metrics_effects_test.ts

@@ -942,7 +942,7 @@ describe('metrics effects', () => {
         actions$.next(TEST_ONLY.initAction());
 
         expect(actualActions).toEqual([
-          actions.metricsUnresolvedPinnedCardsAdded({
+          actions.metricsUnresolvedPinnedCardsFromLocalStorageAdded({
             cards: fakeUniqueCardInfos,
           }),
         ]);

tensorboard/webapp/metrics/store/metrics_reducers.ts

@@ -1514,7 +1514,7 @@ const reducer = createReducer(
   on(actions.metricsSlideoutMenuClosed, (state) => {
     return {...state, isSlideoutMenuOpen: false};
   }),
-  on(actions.metricsUnresolvedPinnedCardsAdded, (state, {cards}) => {
+  on(actions.metricsUnresolvedPinnedCardsFromLocalStorageAdded, (state, {cards}) => {
     return {
       ...state,
       unresolvedImportedPinnedCards: [

tensorboard/webapp/metrics/store/metrics_reducers_test.ts

@@ -4472,16 +4472,16 @@ describe('metrics reducers', () => {
       });
     });
 
-    describe('#metricsUnresolvedPinnedCardsAdded', () => {
-      it('add unresolved pinned card to unresolvedImportedPinnedCards', () => {
+    describe('#metricsUnresolvedPinnedCardsFromLocalStorageAdded', () => {
+      it('adds unresolved pinned card to unresolvedImportedPinnedCards', () => {
         const fakePinnedCard = {tag: 'tagA', plugin: PluginType.SCALARS};
         const state1 = buildMetricsState({
           unresolvedImportedPinnedCards: [],
         });
 
         const state2 = reducers(
           state1,
-          actions.metricsUnresolvedPinnedCardsAdded({cards: [fakePinnedCard]})
+          actions.metricsUnresolvedPinnedCardsFromLocalStorageAdded({cards: [fakePinnedCard]})
         );
         expect(state2.unresolvedImportedPinnedCards).toEqual([fakePinnedCard]);
       });