Skip to content

fix: Update files with correct values for enterprise config #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

dheitepriem
Copy link
Contributor

The newly introduced flag for enterprise_config (added in #2298) can only take in the values STANDARD or ENTERPRISE as by the Google API. The mentioned value of DEFAULT isn't valid

  • Corrected values from DEFAULT to STANDARD
  • Added validation for the variables

@dheitepriem dheitepriem requested review from apeabody, ericyz and a team as code owners March 19, 2025 17:47
Copy link

google-cla bot commented Mar 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Mar 19, 2025
@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dheitepriem!

@apeabody apeabody merged commit cf4cee7 into terraform-google-modules:main Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants